Cedric added this several days ago. http://trac.enlightenment.org/e/changeset/66531
Daniel Juyung Seo (SeoZ) On Sun, Jan 1, 2012 at 6:25 PM, Tom Hacohen <tom.haco...@partner.samsung.com> wrote: > Yeah, calling feed events sounds bad, should be avoided when possible. > > Any news from the original patch author? > > -- > Tom. > > On 29/12/11 14:36, ChunEon Park wrote: >> Cedric, this commit is the result of my review. >> Maybe the original writer could explain this reason. >> ------------------------------------ >> -Regards, Hermet- >> >> -----Original Message----- >> From: "Enlightenment SVN"<no-re...@enlightenment.org> >> To: enlightenment-...@lists.sourceforge.net >> Cc: >> Sent: 11-12-29(목) 21:34:04 >> Subject: E SVN: hermet trunk/elementary/src/lib >> Log: >> elementary/slider - prevent infinite loop. >> >> It looks no need to call the mouse feed events. >> Someone needs to tell the reason. >> >> >> Author: hermet >> Date: 2011-12-29 04:34:04 -0800 (Thu, 29 Dec 2011) >> New Revision: 66630 >> Trac: http://trac.enlightenment.org/e/changeset/66630 >> Modified: >> trunk/elementary/src/lib/elm_slider.c >> Modified: trunk/elementary/src/lib/elm_slider.c >> =================================================================== >> --- trunk/elementary/src/lib/elm_slider.c 2011-12-29 12:03:42 UTC (rev 66629) >> +++ trunk/elementary/src/lib/elm_slider.c 2011-12-29 12:34:04 UTC (rev 66630) >> @@ -446,7 +446,7 @@ >> } >> >> static void >> -_spacer_cb(void *data, Evas *e, Evas_Object *obj __UNUSED__, void >> *event_info) >> +_spacer_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, >> void *event_info) >> { >> Widget_Data *wd = elm_widget_data_get(data); >> Evas_Event_Mouse_Down *ev = event_info; >> @@ -474,11 +474,12 @@ >> { >> edje_object_part_drag_value_set(wd->slider, "elm.dragable.slider", >> button_x, button_y); >> } >> - else >> - { >> - evas_event_feed_mouse_cancel(e, 0, NULL); >> - evas_event_feed_mouse_down(e, 1, EVAS_BUTTON_NONE, 0, NULL); >> - } >> + >> + //What is a purpose of these two mouse events? >> + //I don't know the reason but these calls cause infinite loop. >> + //So blocked them. >> + //evas_event_feed_mouse_cancel(e, 0, NULL); >> + //evas_event_feed_mouse_down(e, 1, EVAS_BUTTON_NONE, 0, NULL); >> } > > > > ------------------------------------------------------------------------------ > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex > infrastructure or vast IT resources to deliver seamless, secure access to > virtual desktops. With this all-in-one solution, easily deploy virtual > desktops for less than the cost of PCs and save 60% on VDI infrastructure > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
