Hello, 2012/1/17 ChunEon Park <her...@naver.com>: > In my opinion, it's enough to add the @deprecated to doxy. > App developers could find the changes when complie warnings show up.
Yes app developers can find the changes IF the deprecated documentation is there forever. I'm not sure the deprecated comments will be there even after elm 1.0. > It's painful to do duplicated things. Yes it is painful. But it's needed. That's why we write ChangeLog and NEWS even they're duplicated 4 times. (code, header, ChangeLog, and NEWS) But elm is not released yet so elm does not have ChangeLog or NEWS, that's why I created ElementaryChanges wiki page. And it's not only for e-devs but also for other app devs as well. Going here and there to find how api's are changed are more painful for more developers. And I realized that there are many applications written in elementary in this world than I expected. And they're seriously disappointed with this huge elementary changes. But you know, API correction and stabilization are inevitable for elm 1.0 release. I don't want elm devs to leave EFL. This is one of the main reasons why ElementaryChanges wiki exists. I guess you understand why that's needed now. Thanks. Daniel Juyung Seo (SeoZ) > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Daniel Juyung Seo"<seojuyu...@gmail.com> > To: enlightenment-devel@lists.sourceforge.net > Cc: enlightenment-...@lists.sourceforge.net > Sent: 12-01-16(월) 20:31:08 > Subject: Re: [E-devel] E SVN: hermet trunk/elementary/src/lib > Thanks. But please update ElementaryChanges. > http://trac.enlightenment.org/e/wiki/ElementaryChanges > I think all API changes/deprecation should be updated on this wiki for > application developers convenience. > API addition does not require this wiki page update though. > Daniel Juyung Seo (SeoZ) > On Mon, Jan 16, 2012 at 12:23 PM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: >> Log: >> elementary - rename an API >> >> elm_object_item_object_get -> elm_object_item_widget_get >> >> >> >> Author: hermet >> Date: 2012-01-15 19:23:32 -0800 (Sun, 15 Jan 2012) >> New Revision: 67235 >> Trac: http://trac.enlightenment.org/e/changeset/67235 >> >> Modified: >> trunk/elementary/src/lib/elm_deprecated.h >> trunk/elementary/src/lib/elm_main.c trunk/elementary/src/lib/elm_menu.c >> trunk/elementary/src/lib/elm_object_item.h >> trunk/elementary/src/lib/elm_toolbar.c >> >> Modified: trunk/elementary/src/lib/elm_deprecated.h >> =================================================================== >> --- trunk/elementary/src/lib/elm_deprecated.h 2012-01-15 22:03:45 UTC (rev >> 67234) >> +++ trunk/elementary/src/lib/elm_deprecated.h 2012-01-16 03:23:32 UTC (rev >> 67235) >> @@ -22,6 +22,19 @@ >> EINA_DEPRECATED EAPI Evas_Object *elm_gen_item_widget_get(const Elm_Gen_Item >> *it); >> >> /** >> + * Get the widget object's handle which contains a given item >> + * >> + * @param it The Elementary object item >> + * @return The widget object >> + * >> + * @note This returns the widget object itself that an item belongs to. >> + * @note Every elm_object_item supports this API >> + * @deprecated Use elm_object_item_widget_get() instead >> + * @ingroup General >> + */ >> +EINA_DEPRECATED EAPI Evas_Object *elm_object_item_object_get(const >> Elm_Object_Item *it); >> + >> +/** >> * @defgroup Toggle Toggle >> * >> * @image html img/widget/toggle/preview-00.png >> >> Modified: trunk/elementary/src/lib/elm_main.c >> =================================================================== >> --- trunk/elementary/src/lib/elm_main.c 2012-01-15 22:03:45 UTC (rev 67234) >> +++ trunk/elementary/src/lib/elm_main.c 2012-01-16 03:23:32 UTC (rev 67235) >> @@ -2008,9 +2008,9 @@ >> } >> >> EAPI Evas_Object * >> -elm_object_item_object_get(const Elm_Object_Item *it) >> +elm_object_item_widget_get(const Elm_Object_Item *it) >> { >> - return ((Elm_Widget_Item *) it)->widget; >> + return WIDGET(it); >> } >> >> EAPI void >> @@ -2181,3 +2181,8 @@ >> return elm_widget_item_tooltip_style_get(item); >> } >> >> +EINA_DEPRECATED EAPI Evas_Object * >> +elm_object_item_object_get(const Elm_Object_Item *it) >> +{ >> + return elm_object_item_widget_get(it); >> +} >> >> Modified: trunk/elementary/src/lib/elm_menu.c >> =================================================================== >> --- trunk/elementary/src/lib/elm_menu.c 2012-01-15 22:03:45 UTC (rev 67234) >> +++ trunk/elementary/src/lib/elm_menu.c 2012-01-16 03:23:32 UTC (rev 67235) >> @@ -1036,7 +1036,7 @@ >> EAPI Evas_Object * >> elm_menu_item_menu_get(const Elm_Object_Item *it) >> { >> - return elm_object_item_object_get(it); >> + return elm_object_item_widget_get(it); >> } >> >> EAPI Elm_Object_Item * >> >> Modified: trunk/elementary/src/lib/elm_object_item.h >> =================================================================== >> --- trunk/elementary/src/lib/elm_object_item.h 2012-01-15 22:03:45 UTC (rev >> 67234) >> +++ trunk/elementary/src/lib/elm_object_item.h 2012-01-16 03:23:32 UTC (rev >> 67235) >> @@ -8,7 +8,7 @@ >> * @note Every elm_object_item supports this API >> * @ingroup General >> */ >> -EAPI Evas_Object *elm_object_item_object_get(const Elm_Object_Item *it); >> +EAPI Evas_Object *elm_object_item_widget_get(const Elm_Object_Item *it); >> >> /** >> * Set a content of an object item >> >> Modified: trunk/elementary/src/lib/elm_toolbar.c >> =================================================================== >> --- trunk/elementary/src/lib/elm_toolbar.c 2012-01-15 22:03:45 UTC (rev >> 67234) >> +++ trunk/elementary/src/lib/elm_toolbar.c 2012-01-16 03:23:32 UTC (rev >> 67235) >> @@ -1259,7 +1259,7 @@ >> elm_toolbar_item_toolbar_get(const Elm_Object_Item *it) >> { >> ELM_OBJ_ITEM_CHECK_OR_RETURN(it, NULL); >> - return elm_object_item_object_get(it); >> + return elm_object_item_widget_get(it); >> } >> >> EAPI void >> >> >> ------------------------------------------------------------------------------ >> RSA(R) Conference 2012 >> Mar 27 - Feb 2 >> Save $400 by Jan. 27 >> Register now! >> http://p.sf.net/sfu/rsa-sfdev2dev2 >> _______________________________________________ >> enlightenment-svn mailing list >> enlightenment-...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Mar 27 - Feb 2 > Save $400 by Jan. 27 > Register now! > http://p.sf.net/sfu/rsa-sfdev2dev2 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
