On Tue, 28 Feb 2012 15:15:27 -0500
Michael Blumenkrantz <[email protected]> wrote:

> On Mon, 27 Feb 2012 23:14:10 -0800
> "Enlightenment SVN" <[email protected]> wrote:
> 
> > Log:
> > Change the toolbar item by using button object.
> >   The toolbar item was edje object. Because edje object cannot be focused,
> > toolbar item cannot be focused, either. But toolbar item should be focused
> > in order to move the focus by each item. Later, we will be able to move the
> > focus by using arrow keyboard. So I change toolbar item to be made up with
> > button object. Since toolbar cannot access button's edje object, the effect
> > of content set and text set is moved in button. 
> >   
> > 
> > Author:       jaehwan
> > Date:         2012-02-27 23:14:10 -0800 (Mon, 27 Feb 2012)
> > New Revision: 68495
> > Trac:         http://trac.enlightenment.org/e/changeset/68495
> > 
> > Modified:
> >   trunk/elementary/src/lib/elm_toolbar.c 
> > 
> 
> Hi,
> 
> It seems this commit has completely broken scaled toolbar icons in my app. I
> have reproduced and committed the behavior to toolbar test 1 in
> elementary_test, and if you could take a look I would appreciate it.

On closer inspection, why was this commit even made? All widgets have internal
"focus next" hooks. This is definitely what should have been used instead.

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to