Hi, I fixed the scale bug. Please test it is work well. And thanks for reporting :)
The reason I changed toolbar is the focus problem. In order to use focus next hook, the items should be able to be focused. But toolbar items were edje object. The edje object cannot be focused. So I changed edje object => button object. And I'm refactoring the toolbar. The reason is the below. In samsung, the customized widget(It works like toolbar) have been used. But for the elementary 1.0 release, we decided to forbid customized widget. So I should have contributed the widget or changed the toolbar to include the option of the customized widget. I decided the latter. I don't want two widgets which have similar role. So I'm changing the toolbar to add some options. The schedule is tight until the elementary 1.0 release. I'm try to maintain the toolbar as it is and just add the options. If there is any mistake, please let me know. I'll fix it ASAP. Thanks. -- Jaehwan Kim. 2012년 2월 29일 수요일에 Michael Blumenkrantz님이 작성: > On Tue, 28 Feb 2012 15:15:27 -0500 > Michael Blumenkrantz <[email protected] <javascript:;>> > wrote: > > > On Mon, 27 Feb 2012 23:14:10 -0800 > > "Enlightenment SVN" <[email protected] <javascript:;>> wrote: > > > > > Log: > > > Change the toolbar item by using button object. > > > The toolbar item was edje object. Because edje object cannot be > focused, > > > toolbar item cannot be focused, either. But toolbar item should be > focused > > > in order to move the focus by each item. Later, we will be able to > move the > > > focus by using arrow keyboard. So I change toolbar item to be made up > with > > > button object. Since toolbar cannot access button's edje object, the > effect > > > of content set and text set is moved in button. > > > > > > > > > Author: jaehwan > > > Date: 2012-02-27 23:14:10 -0800 (Mon, 27 Feb 2012) > > > New Revision: 68495 > > > Trac: http://trac.enlightenment.org/e/changeset/68495 > > > > > > Modified: > > > trunk/elementary/src/lib/elm_toolbar.c > > > > > > > Hi, > > > > It seems this commit has completely broken scaled toolbar icons in my > app. I > > have reproduced and committed the behavior to toolbar test 1 in > > elementary_test, and if you could take a look I would appreciate it. > > On closer inspection, why was this commit even made? All widgets have > internal > "focus next" hooks. This is definitely what should have been used instead. > > > ------------------------------------------------------------------------------ > Keep Your Developer Skills Current with LearnDevNow! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-d2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
