Oops! it gives warning messages?
2012/4/17 ChunEon Park <her...@naver.com>:
> Sorry, I didn't look at it carefully.
> Anyhow, please make it to not print any err/warning messages.
>
>
> Thank you.
>
>
> ------------------------------------
> -Regards, Hermet-
>
>
> -----Original Message-----
> From: "Kim Shinwoo"<kimcinoo....@gmail.com>
> To: "Enlightenment developer
> list"<enlightenment-devel@lists.sourceforge.net>;
> Cc:
> Sent: 2012-04-17 (화) 17:44:34
> Subject: Re: [E-devel] [Patch][elementary_test] test_list
>
> Thanks for your response.
> Even though the list item - lit - is NULL, the
> elm_list_item_prev/next(); does not occur error message.
> But other APIs such as elm_list_item_bring_in(); complains if its
> parameter is NULL. So I checked NULL before using it.
> Should I check the NULL before using elm_list_item_prev/next();?
>
> 2012/4/17 ChunEon Park <hermet>@naver.com>:
> > Found problems here
> >
> >
> > In the test code, you missed NULL check for selected_item_get.
> > elm_list_selected_item_get(li);
> > // if (!li) <-------- NEED this
> >
> >
> > ex)
> > static void
> > _prev_bt_clicked(void *data, Evas_Object *obj __UNUSED__,
> > void *event_info __UNUSED__)
> > {
> > ....
> > Elm_Object_Item *lit = elm_list_selected_item_get(li);
> > <------------------- YOU MISSED NULL CHECK "LIT" HERE.
> > lit = elm_list_item_prev(lit);
> > if (!lit) return;
> >
> >
> >
> > static void
> > _next_bt_clicked(void *data, Evas_Object *obj __UNUSED__,
> > void *event_info __UNUSED__)
> > {
> > ....
> > Elm_Object_Item *lit = elm_list_selected_item_get(li);
> > <------------------- MISSED SAME NULL CHECKING!!
> > lit = elm_list_item_prev(lit);
> > if (!lit) return;
> >
> >
> >
> >
> > -----Original Message-----
> > From: "cnook"<kimci...@gmail.com>
> > To: "EFL"<enlightenment-devel@lists.sourceforge.net>;
> > Cc:
> > Sent: 2012-04-17 (화) 13:35:19
> > Subject: [E-devel] [Patch][elementary_test] test_list
> >
> > Dear All, Hello.
> >
> > I had added test code for the elementary. but I made a pause it because
> of
> > some reasons and just started again.
> > Today I have attached a patch for the elm_list which does not have test
> > code for the API elm_list_item_prev();
> > Please review the attached patch and give any feedbacks. I'll be back
> with
> > other patches. Thanks!
> >
> > Sincerely,
> > Shinwoo Kim.
> >
> ------------------------------------------------------------------------------
> > Better than sec? Nothing is better than sec when it comes to
> > monitoring Big Data applications. Try Boundary one-second
> > resolution app monitoring today. Free.
> >
> http://p.sf.net/sfu/Boundary-dev2dev_______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> ------------------------------------------------------------------------------
> > Better than sec? Nothing is better than sec when it comes to
> > monitoring Big Data applications. Try Boundary one-second
> > resolution app monitoring today. Free.
> > http://p.sf.net/sfu/Boundary-dev2dev
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> ------------------------------------------------------------------------------
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
