Thanks for your response. Your review is always great. :) 2012/4/19 Daniel Juyung Seo <seojuyu...@gmail.com>: > Belated review. > I have some comments. I just committed the fixed version but it'll be > good for you to know. > > 1) two spaces between "bt," and "4"!!. >> elm_grid_pack(gd, bt, 4, 80, 20, 10); > There were more than 10 instances of this. I fixed it. > > 2) internal function position > I moved _first/prev/next/last_bt_clicked() callback functions to the > right before test_list6() function. > They are used for test_list6(). > > 3) casting >> Evas_Object *li = (Evas_Object *) data; > You don't need to cast void pointer. > Just do > Evas_Object *li = data; > > Otherwise, it is a good patch! > Here is the link of my fix. > http://trac.enlightenment.org/e/changeset/70317 > > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Tue, Apr 17, 2012 at 8:20 PM, Kim Shinwoo <kimcinoo....@gmail.com> wrote: >> hehe~ I like grid! >> hmm.. If you want... I will be back with the box! >> >> 2012/4/17 Carsten Haitzler <ras...@rasterman.com>: >>> On Tue, 17 Apr 2012 13:35:19 +0900 cnook <kimci...@gmail.com> said: >>> >>>> Dear All, Hello. >>>> >>>> I had added test code for the elementary. but I made a pause it because of >>>> some reasons and just started again. >>>> Today I have attached a patch for the elm_list which does not have test >>>> code for the API elm_list_item_prev(); >>>> Please review the attached patch and give any feedbacks. I'll be back with >>>> other patches. Thanks! >>> >>> in - with null item fetch changes in as chuneon was mentioning. >>> >>> also.. just style-wise.. WHY a grid? why? why why why? its really a widget u >>> DONT want to go using... much.. ever! >>> >>> -- >>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >>> The Rasterman (Carsten Haitzler) ras...@rasterman.com >>> >>> >>> ------------------------------------------------------------------------------ >>> Better than sec? Nothing is better than sec when it comes to >>> monitoring Big Data applications. Try Boundary one-second >>> resolution app monitoring today. Free. >>> http://p.sf.net/sfu/Boundary-dev2dev >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> ------------------------------------------------------------------------------ >> Better than sec? Nothing is better than sec when it comes to >> monitoring Big Data applications. Try Boundary one-second >> resolution app monitoring today. Free. >> http://p.sf.net/sfu/Boundary-dev2dev >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > For Developers, A Lot Can Happen In A Second. > Boundary is the first to Know...and Tell You. > Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! > http://p.sf.net/sfu/Boundary-d2dvs2 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
