Well... In my opinion, Unnecessary code should be removed to reduce size and operations and to maintain code more clearly.
This patch anyway seemed not fix the problem, because outside of that function, "st" can be accessed still. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Hyoyoung Chang"<hyoyo...@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2012-05-17 (목) 16:30:56 Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib On Thu, May 17, 2012 at 4:02 PM, ChunEon Park <hermet>@naver.com> wrote: > I wonder why st is NULL. > > > I think we need to prevent to not go that function in advance, if the st was invalid. Yeah, u'r right. btw, below code is to check about st->l, because if st->l is NULL, it can be return with EINA_TRUE. "!st" is just precondition. i think it can be removed. but it's convenient. isn't it? > > > ------------------------------------ > -Regards, Hermet- > > > -----Original Message----- > From: "Hyoyoung Chang"<hyoyo...@gmail.com> > To: <enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2012-05-17 (목) 13:44:26 > Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib > > Thanks, in svn - r71187 > > On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN > <no-reply>@enlightenment.org> wrote: > > Log: > > elementary/gesture_layer: add to null check at _tap_gesture_check_finish > > > > Signed-off-by: Kim Shinwoo <kimcinoo.efl>@gmail.com> > > > > > > Author: hyoyoung > > Date: 2012-05-16 21:39:40 -0700 (Wed, 16 May 2012) > > New Revision: 71187 > > Trac: http://trac.enlightenment.org/e/changeset/71187 > > > > Modified: > > trunk/elementary/src/lib/elm_gesture_layer.c > > > > Modified: trunk/elementary/src/lib/elm_gesture_layer.c > > =================================================================== > > --- trunk/elementary/src/lib/elm_gesture_layer.c 2012-05-17 04:05:26 UTC (rev 71186) > > +++ trunk/elementary/src/lib/elm_gesture_layer.c 2012-05-17 04:39:40 UTC (rev 71187) > > @@ -1185,6 +1185,7 @@ > > Taps_Type *st = gesture->data; > > Eina_List *l; > > Eina_List *pe_list; > > + if (!st || !st->l) return EINA_FALSE; > > EINA_LIST_FOREACH(st->l, l, pe_list) > > { > > if (eina_list_count(pe_list) != st->n_taps_needed) > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
