um.. If the st is NULL, then st->l in EINA_LIST_FOREACH occurs segmentation fault.. so.. checking NULL without return statement.. is meaningless.. ok.. then I will send a patch again.
Thanks for your response. 2012/5/17 Kim Shinwoo <kimcinoo....@gmail.com>: > Actually, only st->l would be NULL not st. > > So, > > + if (!st->l) return EINA_FALSE; > > is enough to me. > > Even though I'm not sure when the st is NULL, I cannot guarantee the > st is always not NULL > > > > 2012/5/17 ChunEon Park <her...@naver.com>: >> I wonder why st is NULL. >> >> >> I think we need to prevent to not go that function in advance, if the st was >> invalid. >> >> >> ------------------------------------ >> -Regards, Hermet- >> >> >> -----Original Message----- >> From: "Hyoyoung Chang"<hyoyo...@gmail.com> >> To: <enlightenment-devel@lists.sourceforge.net>; >> Cc: >> Sent: 2012-05-17 (목) 13:44:26 >> Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib >> >> Thanks, in svn - r71187 >> >> On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN >> <no-reply>@enlightenment.org> wrote: >> > Log: >> > elementary/gesture_layer: add to null check at _tap_gesture_check_finish >> > >> > Signed-off-by: Kim Shinwoo <kimcinoo.efl>@gmail.com> >> > >> > >> > Author: hyoyoung >> > Date: 2012-05-16 21:39:40 -0700 (Wed, 16 May 2012) >> > New Revision: 71187 >> > Trac: http://trac.enlightenment.org/e/changeset/71187 >> > >> > Modified: >> > trunk/elementary/src/lib/elm_gesture_layer.c >> > >> > Modified: trunk/elementary/src/lib/elm_gesture_layer.c >> > =================================================================== >> > --- trunk/elementary/src/lib/elm_gesture_layer.c 2012-05-17 >> 04:05:26 UTC (rev 71186) >> > +++ trunk/elementary/src/lib/elm_gesture_layer.c 2012-05-17 >> 04:39:40 UTC (rev 71187) >> > @@ -1185,6 +1185,7 @@ >> > Taps_Type *st = gesture->data; >> > Eina_List *l; >> > Eina_List *pe_list; >> > + if (!st || !st->l) return EINA_FALSE; >> > EINA_LIST_FOREACH(st->l, l, pe_list) >> > { >> > if (eina_list_count(pe_list) != st->n_taps_needed) >> > >> > >> > >> ------------------------------------------------------------------------------ >> > Live Security Virtual Conference >> > Exclusive live event will cover all the ways today's security and >> > threat landscape has changed and how IT managers can respond. >> Discussions >> > will include endpoint security, mobile security and the latest in >> malware >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > _______________________________________________ >> > enlightenment-svn mailing list >> > enlightenment-...@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
