I think... your comment is ambiguous..
User may expect the false when they call the elm_config_cache_flush_enabled_get. I just added comment by myself. * @note The @p size must greater than 0. if not, the cache flush will be ignored. Anyway, thank you for reporting. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Bluezery"<[email protected]> To: "Enlightenment developer list"<[email protected]>; <[email protected]>; Cc: Sent: 2012-05-22 (화) 11:47:42 Subject: Re: [E-devel] [Patch][elm_config]check if input value, cache_flush_poll_interval is greater than zero 2012/5/21 ChunEon Park <hermet>@naver.com>: > > Actually, both cases almost same. > But your patch would not be able to prevent the invalid flush value when it is loaded from the config file. Yes, right.. ! It is better to change the documentation. Please review again. And it would be better to change the input parameter from "int" to "unsigned int" later. > > ------------------------------------ > > -Regards, Hermet- > > > > -----Original Message----- > From: "Bluezery"<[email protected]> > To: "Enlightenment developer list"<[email protected]>; > Cc: > Sent: 2012-05-21 (월) 16:12:16 > Subject: [E-devel] [Patch][elm_config]check if input value, cache_flush_poll_interval is greater than zero > > Hello, > > "_elm_config->cache_flush_poll_interval" is used for flushing cache by > ecore poller. > If this value is not greater than 0, poller is disabled. > But, I think that this value should be greater than 0 because there > already exists "cache_flush_enable" for enable/disable cache poller. > > Please review this patch. > Thanks. > > -- > BRs, > Kim. > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- BRs, Kim. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
