On Thu, 24 May 2012 13:37:47 +0900 Bluezery <[email protected]> said:
> 2012/5/24 Carsten Haitzler <[email protected]>: > > On Mon, 21 May 2012 16:12:16 +0900 Bluezery <[email protected]> said: > > > >> Hello, > >> > >> "_elm_config->cache_flush_poll_interval" is used for flushing cache by > >> ecore poller. > >> If this value is not greater than 0, poller is disabled. > >> But, I think that this value should be greater than 0 because there > >> already exists "cache_flush_enable" for enable/disable cache poller. > >> > >> Please review this patch. > >> Thanks. > > > > this is testing for sanity. remember these config values come from on-disk > > files or properties that could be corrupted. a poll interval of 0 "makes no > > sense". :/ so... what is this fixing? :) > > I overlooked the config value. > Anyway, this patch is not in and just documentation was fixed. B-) > IMHO, if below zero makes no sense, the input parameter type could be > better to be changed from "int" to "unsigned int" and from "EET_T_INT" > to "EET_T_UINT" at next release. unsigned int still can be 0. :) and no - patch isnt in. at least the first hunk i think is not so wise to remove the check if its > 0. the 2nd one we could put in. > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) [email protected] > > > > > > -- > BRs, > Kim. > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
