1. do not cast in this case 2. no space for casting yes we have some wrong formatted codes, just fix them when we find them. On May 25, 2012 12:21 AM, "Carsten Haitzler" <[email protected]> wrote:
> On Thu, 24 May 2012 11:12:31 -0300 Gustavo Sverzut Barbieri > <[email protected]> said: > > > On Thu, May 24, 2012 at 11:09 AM, Carsten Haitzler <[email protected] > > > > wrote: > > > On Thu, 24 May 2012 16:51:07 +0300 Tom Hacohen < > [email protected]> > > > said: > > > > > >> On 24/05/12 16:46, Gustavo Sverzut Barbieri wrote: > > >> > On Wed, May 23, 2012 at 11:38 PM, Enlightenment SVN > > >> > <[email protected]> wrote: > > >> >> > > >> >> Log: > > >> >> elementary/hoversel: fix indent > > >> >> > > >> >> > > >> >> Author: hyoyoung > > >> >> Date: 2012-05-23 19:38:59 -0700 (Wed, 23 May 2012) > > >> >> New Revision: 71377 > > >> >> Trac: http://trac.enlightenment.org/e/changeset/71377 > > >> >> > > >> >> Modified: > > >> >> trunk/elementary/src/lib/elc_hoversel.c > > >> >> > > >> >> Modified: trunk/elementary/src/lib/elc_hoversel.c > > >> >> =================================================================== > > >> >> --- trunk/elementary/src/lib/elc_hoversel.c 2012-05-24 > 02:26:55 UTC > > >> >> (rev 71376) +++ trunk/elementary/src/lib/elc_hoversel.c > 2012-05-24 > > >> >> 02:38:59 UTC (rev 71377) @@ -230,7 +230,7 @@ > > >> >> Evas_Object *obj __UNUSED__, > > >> >> void *event_info __UNUSED__) > > >> >> { > > >> >> - elm_hoversel_hover_parent_set((Evas_Object*)data, NULL); > > >> >> + elm_hoversel_hover_parent_set((Evas_Object *)data, NULL); > > >> >> } > > >> > > > >> > If you're fixing indent, then remove this ugly (Evas_Object*) cast. > > >> > It's not required in C. > > >> > > >> Or if you keep it, at least add a space before the "data" i.e > > >> "(Evas_Object *) data". > > > > > > we've never added spaces after casts before... historically. > > > > no casts, they are bad... bad ;-) > > i know in this case we dont need a cast. in fact in many cases we don't. c > auto-casts many things for us where its "safe". just talking about the > formatting only. > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
