On Wed, 23 May 2012 18:59:34 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
in this case its cleaner to do without a goto. gotos are not the best thing ever - sometimes we use them for things like try/catch exception handling and some specific cases where not using a goto would make the code much harder to read/maintain, but in this case it's easier not to use it. fixed in svn. > Do we really need go to here? > It looks clean but I want to avoid using goto too many places without > necessity. > > Daniel Juyung Seo (SeoZ) > > On Wed, May 23, 2012 at 4:31 PM, Enlightenment SVN > <no-re...@enlightenment.org> wrote: > > Log: > > elementary/genlist: add short cut in item bring in calc. > > fix compress_mode documentation. > > > > > > Author: hyoyoung > > Date: 2012-05-23 00:31:03 -0700 (Wed, 23 May 2012) > > New Revision: 71349 > > Trac: http://trac.enlightenment.org/e/changeset/71349 > > > > Modified: > > trunk/elementary/src/lib/elm_genlist.c > > trunk/elementary/src/lib/elm_genlist.h > > > > Modified: trunk/elementary/src/lib/elm_genlist.c > > =================================================================== > > --- trunk/elementary/src/lib/elm_genlist.c 2012-05-23 04:32:00 UTC > > (rev 71348) +++ trunk/elementary/src/lib/elm_genlist.c 2012-05-23 > > 07:31:03 UTC (rev 71349) @@ -4955,6 +4955,9 @@ > > Elm_Gen_Item *_it = (Elm_Gen_Item *)it; > > Evas_Coord gith = 0; > > if (_it->generation < _it->wd->generation) return EINA_FALSE; > > + if ((_it->wd->homogeneous) && > > + (_it->wd->mode == ELM_LIST_COMPRESS)) > > + goto hm_shortcut; /* homogenous genlist shortcut */ > > if ((_it->item->queued) || (!_it->item->mincalcd)) > > { > > _it->wd->show_item = _it; > > @@ -4963,6 +4966,7 @@ > > _it->item->showme = EINA_TRUE; > > return EINA_FALSE; > > } > > +hm_shortcut: > > if (_it->wd->show_item) > > { > > _it->wd->show_item->item->showme = EINA_FALSE; > > > > Modified: trunk/elementary/src/lib/elm_genlist.h > > =================================================================== > > --- trunk/elementary/src/lib/elm_genlist.h 2012-05-23 04:32:00 UTC > > (rev 71348) +++ trunk/elementary/src/lib/elm_genlist.h 2012-05-23 > > 07:31:03 UTC (rev 71349) @@ -516,9 +516,11 @@ > > * @note ELM_LIST_COMPRESS will make list resize slower as it will have to > > * recalculate every item height again whenever the list width > > * changes! > > - * @note When ELM_LIST_COMPRESS mode is enabled, it also enables > > - * compress mode (see elm_genlist_mode_set()) and > > - * disables homogeneous (see elm_genlist_homogeneous_set()). > > + * @note Homogeneous mode is for that all items in the genlist same > > + * width/height. With ELM_LIST_COMPRESS, it makes genlist items to > > fast > > + * initializing. However there's no sub-objects in genlist which can > > be > > + * on the flying resizable (such as TEXTBLOCK). If then, some dynamic > > + * resizable objects in genlist would not diplayed properly. > > * > > * @see elm_genlist_mode_get() > > * > > @@ -1326,8 +1328,7 @@ > > * > > * This will enable the homogeneous mode where items are of the same > > * height and width so that genlist may do the lazy-loading at its > > - * maximum (which increases the performance for scrolling the list). This > > - * implies 'compressed' mode. > > + * maximum (which increases the performance for scrolling the list). > > * > > * @see elm_genlist_mode_set() > > * @see elm_genlist_homogeneous_get() > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
