<dori...@profusion.mobi>, It was my fantasy to use NULL as parameter. There are some NULL checks in functions calling those below but not everywhere.
Ok, fine, you don't have to check NULL here, but it would be nice, more user friendly, if although there would be some information in documentation to functions, which use those in patch, not to use NULL parameter, e.g. in edje_object_part_text_insert() or elm_entry_entry_insert(), because they don't have NULL checks. Or simply add these NULL checks there. Thank you for your opinion. -----Original Message----- From: Daniel Juyung Seo [mailto:seojuyu...@gmail.com] Sent: Friday, September 21, 2012 4:08 AM To: Enlightenment developer list Subject: Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file NULL checks again! Daniel Juyung Seo (SeoZ) On Fri, Sep 21, 2012 at 2:27 AM, Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > On Thu, Sep 20, 2012 at 11:50 AM, Leandro Dorileo > <dori...@profusion.mobi> wrote: >> Hi Beata, >> >> On Thu, Sep 20, 2012 at 11:19:57AM +0200, KoziarekBeata wrote: >>> Hi, >>> >>> >>> >>> This patch contains NULL checks for some functions in edje_entry file. >>> >>> Lack of these NULL checks after calling these function causes >>> segmentation faults. >>> >> >> >> >> I'm afraid your patch hides the "real" bug. Those pointers shouldn't >> be checked before actually calling the functions you've changed? Why >> are those pointers NULL? > > some people like to remove trailing whitespace, some add those checks > :-) > > > -- > Gustavo Sverzut Barbieri > http://profusion.mobi embedded systems > -------------------------------------- > MSN: barbi...@gmail.com > Skype: gsbarbieri > Mobile: +55 (19) 9225-2202 > > ---------------------------------------------------------------------- > -------- Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics Download AppDynamics Lite > for free today: > http://ad.doubleclick.net/clk;258768047;13503038;j? > http://info.appdynamics.com/FreeJavaPerformanceDownload.html > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ---------------------------------------------------------------------------- -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
