On Thu, 20 Sep 2012 11:19:57 +0200 KoziarekBeata <b.kozia...@samsung.com> said:
i'm going to be a bit harsh here.. :( but.. it'd be nice if you didn't make 99% of your patch whitepsace changes? it really discourages review - when u see a long patch u delay it only to find.. its all wasted stuff. :-P so please.. next time... strip whitepsace changes? or don't go making them unless u want to make separate whitespace patches? :) ok - in and i stripped the whitepsace changes out of the patch > Hi, > > > > This patch contains NULL checks for some functions in edje_entry file. > > Lack of these NULL checks after calling these function causes segmentation > faults. > > > > Please find attached file and give me some feedback. > > > > Regards, > > Beata > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
