On Wed, Jan 9, 2013 at 10:40 PM, Joel Klinghed <the...@spawned.biz> wrote: > On Wed, 9 Jan 2013 14:49:07 -0200 > Gustavo Sverzut Barbieri <barbi...@profusion.mobi> wrote: > >> committed as it will help you, but would be nice to simplify even >> further. [...] > Todays patch then. I removed the header, libs and functions checks when > pkg-config is used. > Started moving ECORE_X and ECORE_IMF_XIM to use EFL_LIB_START ... > ended up doing the same with all the evas_engines - I might have gone a > bit overboard here but it is more consistent... > Anyway, it works for me, compile tested (./configure && make gave no > error) X11, XCB and SDL, all with GL and with and without pkg-config.
Hi Joel, Sorry but I moved on with configure.ac and forgot about this patch, could you provide a new patch considering the following comments: - do not abuse the EFL_LIB_* macros for internal modules, I plan to do some extra stuff with them later, such as automatic library and module reporting. Maybe do similar (likely simpler) versions for modules? It seems that it will be useful to make modules handling more standard and less error prone. Check if it's feasible to do with a small subset, if we end doing replicating the whole thing, then better keep your way. - use the m4_ prefixed macros (popdef, pushdef..) - don't do AC_DEFINE([ECORE_[]UP], [0], [Build support for $1]) for every module, as the code checks for "#ifdef" not #if" - rename ECORE_ADD_X_EXTENSION -> XLIB? Maybe add a start/end so we can remove those variables and loops from the configure.ac... Although it improved a lot with your patch, this X handling is still too-exposed. If we could shrink it to something like XCB then it would be awesome. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
