Sorry for breaking the mail thread. I haven't known that. I will use another mail client.
Regards, Thiep ------- Original Message ------- Sender : Carsten Haitzler<ras...@rasterman.com> Date : Feb 18, 2013 21:24 (GMT+09:00) Title : Re: [E-devel] [PATCH] [Elementary] Patch to fix elementary list with separator On Mon, 18 Feb 2013 20:56:51 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said: > On Mon, Feb 18, 2013 at 6:29 PM, Carsten Haitzler <ras...@rasterman.com>wrote: > > > On Mon, 18 Feb 2013 17:27:46 +0900 Daniel Juyung Seo <seojuyu...@gmail.com > > > > > said: > > > > > On Mon, Feb 18, 2013 at 5:13 PM, Carsten Haitzler <ras...@rasterman.com > > >wrote: > > > > > > > On Wed, 2 Jan 2013 19:13:00 +0900 Daniel Juyung Seo < > > seojuyu...@gmail.com> > > > > said: > > > > > > > > > Oops Thiep, sorry I didn't review test_list.c > > > > > So here are more comments. > > > > > > > > > > 1. api_data > > > > > api_data *api = calloc(1, sizeof(api_data));$ > > > > > > > > > > api_data is not used in test_list_separator() so remove it and > > related > > > > > codes. > > > > > > > > > > 2. test_list_separator(xxx) indentation > > > > > Indentations for test_list_separator(xxx) are wrong. > > > > > > > > > > +test_list_separator(void *data __UNUSED__, > > > > > + Evas_Object *obj __UNUSED__, > > > > > + void *event_info __UNUSED__) > > > > > > > > > > Thanks. > > > > > > > > > > > Hello > > > > > > > > > > i didnt see a followup from this in email... but some of the patch is > > in > > > > svn i > > > > think at least.. is this done? :) > > > > > > > > > > I guess you missed my reply. > > > > its not in my mailer in this thread.. did your mailer break the thread > > again? > > (like oh so many people do making it impossible to follow threads). :) > > > Well I don't think so. Gmail works very fine with this kind of mail thread. > The title is still "Re: [E-devel] [PATCH] [Elementary] Patch to fix > elementary list with separator". > It should work. thieps mail broke it. clients break thread by removing the In-Reply-To field in the header. this is the header that for the past what 15.. 20 years has been used by mail clients to figure out threads. it knows WHAT mail id this was in reply to... a mailer will assign a unique id with Message-ID when you send it, so mail clients can "trace" these id's and reply tos and do a thread correctly and repliably. thats how it can do multiple levels of nesting etc. too. gmail GUESSES by the subject being the same with an Re: that it might be a thread. but it cant know exactly what you reply to like a proper nesting thread unless you use such mail id's. bad mail clients are unsociable and break such threads by simply posting a whole new mail to the list with no context/reference what it is in reply to. it breaks other peoples ability to track the conversation properly even though for like 20 years clients have been playing nice. now they just don't bother and are rude and remove such threading info. > > > >> Thanks in SVN! > > > >> Please modify ChangeLog and NEWS files when you fix a bug which was > > > included in the released version. > > > >> I did it for you this time. > > > >> http://trac.enlightenment.org/e/changeset/82040< > > http://trac.enlightenment.org/e/changeset/82040> > > > >> http://trac.enlightenment.org/e/changeset/82041 > > > > > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > On Wed, Jan 2, 2013 at 6:53 PM, Daniel Juyung Seo < > > seojuyu...@gmail.com > > > > >wrote: > > > > > > > > > > > Dear Thiep, thanks a lot for your bug fix. > > > > > > There was an explicit bug on elm list separator. > > > > > > And I have some comments. > > > > > > > > > > > > 1. elementary-1.7 > > > > > > Please support the same patches to elementary-1.7. > > > > > > > > > > > > 2. it->deleted checks > > > > > > it->deleted checks in elm_list.c:600 is not needed. > > > > > > It was already checked. > > > > > > > > > > > > 3. it->separator_themed > > > > > > separator_themed is not needed. > > > > > > it->fixed does the same job. > > > > > > > > > > > > 4. code structure > > > > > > I think you can reuse some existing code. > > > > > > Move 38 ~ 47 lines of your patch to the following parts and reuse > > the > > > > code. > > > > > > if (!it->fixed) ... > > > > > > If my explanation is ambigous I will do the refactoring once your > > code > > > > is > > > > > > committed. > > > > > > > > > > > > Thanks. > > > > > > > > > > > > Daniel Juyung Seo (SeoZ) > > > > > > > > > > > > > > > > > > On Sun, Dec 30, 2012 at 3:03 PM, Thiep Ha <thie...@gmail.com> > > wrote: > > > > > > > > > > > >> Hi all, > > > > > >> > > > > > >> I sent this patch before, but there is no reply. > > > > > >> So, I resend it. > > > > > >> Since separators in list are not correctly applied (always have > > same > > > > size > > > > > >> with other items), > > > > > >> this patch is sent to fix that. > > > > > >> Could someone review it? > > > > > >> > > > > > >> Thanks, > > > > > >> Thiep > > > > > >> > > > > > >> > > > > > >> > > > > > >> From: thiep ha <thiep...@samsung.com> > > > > > >> > Date: Sun, Dec 9, 2012 at 11:11 AM > > > > > >> > Subject: [E-devel] [Patch] [Elementary] Patch to fix elementary > > list > > > > > >> with > > > > > >> > separator > > > > > >> > To: "enlightenment-devel@lists.sourceforge.net" < > > > > > >> > enlightenment-devel@lists.sourceforge.net> > > > > > >> > > > > > > >> > > > > > > >> > Dear All, > > > > > >> > > > > > > >> > In elementary list, the separator is not correctly set. > > > > > >> > I would like to send a patch to correct the list with separator. > > > > > >> > I also add an example named "List Separator" to test it. > > > > > >> > > > > > > >> > Please review this patch. > > > > > >> > > > > > > >> > Best Regards, > > > > > >> > Thiep Ha > > > > > >> > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > > ------------------------------------------------------------------------------ > > > > > >> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, > > CSS, > > > > > >> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills > > > > current > > > > > >> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft > > > > > >> MVPs and experts. ON SALE this month only -- learn more at: > > > > > >> http://p.sf.net/sfu/learnmore_123012 > > > > > >> _______________________________________________ > > > > > >> enlightenment-devel mailing list > > > > > >> enlightenment-devel@lists.sourceforge.net > > > > > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > > Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, > > jQuery > > > > > and much more. Keep your Java skills current with LearnJavaNow - > > > > > 200+ hours of step-by-step video tutorials by Java experts. > > > > > SALE $49.99 this month only -- learn more at: > > > > > http://p.sf.net/sfu/learnmore_122612 > > > > > _______________________________________________ > > > > > enlightenment-devel mailing list > > > > > enlightenment-devel@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > > > > > > > -- > > > > ------------- Codito, ergo sum - "I code, therefore I am" > > -------------- > > > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > The Go Parallel Website, sponsored by Intel - in partnership with > > Geeknet, > > > is your hub for all things parallel software development, from weekly > > thought > > > leadership blogs to news, videos, case studies, tutorials, tech docs, > > > whitepapers, evaluation guides, and opinion stories. Check out the most > > > recent posts - join the conversation now. > > http://goparallel.sourceforge.net/ > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > ------------------------------------------------------------------------------ > The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, > is your hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials, tech docs, > whitepapers, evaluation guides, and opinion stories. Check out the most > recent posts - join the conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials, tech docs, whitepapers, evaluation guides, and opinion stories. Check out the most recent posts - join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel <p> </p><p> </p> ------------------------------------------------------------------------------ The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials, tech docs, whitepapers, evaluation guides, and opinion stories. Check out the most recent posts - join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
