On 16/05/13 14:06, Jérémy Zurcher wrote: > sorry, but what are those formatting changes ??
Removing the parens that were there. > … > I see your commits, > clang yells loud about this, many people are moving from gcc to clang, > your code will keep yelling so, not really an issue for me. > Really could care less what clang says to be honest :) They are ?? who ?? Distros still ship with gcc as the default compiler afaik....Well, it does not yell here so not really an issue for me either ;) dh > On Thursday 16 May 2013 12:59, Christopher Michael wrote : >> Please revert this !!! and re-apply WITHOUT the formatting changes !!!! >> >> dh >> >> On 16/05/13 12:18, J챕r챕my Zurcher - Enlightenment Git wrote: >>> jeyzu pushed a commit to branch master. >>> >>> commit ab505d5d23299e658b39fa7d0f1aa73742e3e7fb >>> Author: Jérémy Zurcher <jer...@asynk.ch> >>> Date: Wed May 15 16:42:31 2013 +0200 >>> >>> ecore evas wayland: if(()) are used for assignments, add missing NULL >>> fields >>> --- >>> src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_egl.c | 4 ++-- >>> src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c | 8 >>> +++++--- >>> 2 files changed, 7 insertions(+), 5 deletions(-) >>> >>> diff --git >>> a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_egl.c >>> b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_egl.c >>> index 3aa60bf..820f001 100644 >>> --- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_egl.c >>> +++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_egl.c >>> @@ -435,7 +435,7 @@ _ecore_evas_wl_alpha_set(Ecore_Evas *ee, int alpha) >>> LOGFN(__FILE__, __LINE__, __FUNCTION__); >>> >>> if (!ee) return; >>> - if ((ee->alpha == alpha)) return; >>> + if (ee->alpha == alpha) return; >>> ee->alpha = alpha; >>> >>> wdata = ee->engine.data; >>> @@ -463,7 +463,7 @@ _ecore_evas_wl_transparent_set(Ecore_Evas *ee, int >>> transparent) >>> LOGFN(__FILE__, __LINE__, __FUNCTION__); >>> >>> if (!ee) return; >>> - if ((ee->transparent == transparent)) return; >>> + if (ee->transparent == transparent) return; >>> ee->transparent = transparent; >>> >>> wdata = ee->engine.data; >>> diff --git >>> a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c >>> b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c >>> index 2bac6f1..93e3361 100644 >>> --- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c >>> +++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c >>> @@ -76,7 +76,9 @@ static Ecore_Evas_Engine_Func _ecore_wl_engine_func = >>> NULL, // focus skip set >>> NULL, //_ecore_evas_wl_common_render, >>> _ecore_evas_wl_common_screen_geometry_get, >>> - _ecore_evas_wl_common_screen_dpi_get >>> + _ecore_evas_wl_common_screen_dpi_get, >>> + NULL, // func msg parent send >>> + NULL // func msg send >>> }; >>> >>> /* external variables */ >>> @@ -458,7 +460,7 @@ _ecore_evas_wayland_shm_alpha_do(Ecore_Evas *ee, int >>> alpha) >>> LOGFN(__FILE__, __LINE__, __FUNCTION__); >>> >>> if (!ee) return; >>> - if ((ee->alpha == alpha)) return; >>> + if (ee->alpha == alpha) return; >>> ee->alpha = alpha; >>> wdata = ee->engine.data; >>> >>> @@ -507,7 +509,7 @@ _ecore_evas_wayland_shm_transparent_do(Ecore_Evas *ee, >>> int transparent) >>> LOGFN(__FILE__, __LINE__, __FUNCTION__); >>> >>> if (!ee) return; >>> - if ((ee->transparent == transparent)) return; >>> + if (ee->transparent == transparent) return; >>> ee->transparent = transparent; >>> >>> wdata = ee->engine.data; >>> >> >> >> ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
