On 16/05/13 14:24, Christopher Michael wrote: > On 16/05/13 14:19, Tom Hacohen wrote: >> On 16/05/13 14:17, Christopher Michael wrote: >>> On 16/05/13 14:14, Tom Hacohen wrote: >>>> On 16/05/13 14:06, Christopher Michael wrote: >>>>> On 16/05/13 14:06, Jérémy Zurcher wrote: >>>>>> sorry, but what are those formatting changes ?? >>>>> >>>>> Removing the parens that were there. >>>>> >>>>>> … >>>>>> I see your commits, >>>>>> clang yells loud about this, many people are moving from gcc to >>>>>> clang, >>>>>> your code will keep yelling so, not really an issue for me. >>>>>> >>>>> >>>>> Really could care less what clang says to be honest :) They are ?? who >>>>> ?? Distros still ship with gcc as the default compiler >>>>> afaik....Well, it >>>>> does not yell here so not really an issue for me either ;) >>>> >>>> To be fair, that (()) clutter is ugly > > Ugly ?? Have you ever looked inside Elementary code ?? Now THAT's ugly ;) > > and should be removed even if >>>> clang doesn't complain. Why do you care so much for it anyway? >>>> >>>> -- >>>> Tom. >>>> >>> >>> It helps me keep my sanity when dealing with unruley if blocks and truth >>> tests. Well, one man's ugly is another man's beauty I suppose ;) >> >> How does it help you? I'm genuinely interested. >> >> -- >> Tom. >> > > > Order of precedence and readability mainly.
Double parenthesis don't change the order of precedence. It's fine (and required by our conventions) if you had an AND or OR there, but since you don't have those, it just looks weird. -- Tom. ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel