On Fri, 9 Aug 2013 23:57:28 -0300 Gustavo Sverzut Barbieri <barbi...@gmail.com> said:
in principle i don't have a problem with this... but the patch as it stands does have several issues that i'd say a "no" to right now. 1. terminal sizing is wrong. the standard 80x24 term doesnt come up at 80x24.. if the menu is CONSUMING space inside the window... :) if u dont have a global menu daemon then this is broken. :) eg i size my term down to its smallest size, e reports 80x5.. but its actually 80x1 - so base size and so on are not handled properly. if the menu bar is inside the window i'd expect the window to be a little taller by default with the 80x24 term as we saw it before a menu bar, sitting below the menu bar, same size etc. 2. i agree look-wise its ugly as sin... admittedly dark looks better.. but its also fat and horrible right now - work needs doing on the theme though. 3. given the ugliness of it at least right now, could there be a CONFIG option (in elm's config) to turn it off? and have it off by default for now at least until such a time as it behaves and looks decently? once menus look good in elm by default - i'm willing to have it on by default (for #3). :) > Hi, > > Since Elementary makes it easy to add an application menu and E18 > supports the "external dbus menu" protocol to have it outside of the > screen I've implemented that in terminology. > > It shows "Terminology" entry with "Settings" and "About" subentries, > "Terminal" with new, split and close. Then "Edit" with Copy and Paste > and last show the existent tabs/views. > > I've decided to ask for some feedback whenever we want this, if one > doesn't have the "external dbus menu" support (no e18 gadget or other > wm supporting) it will show a menu bar that is currently unthemed -- > will show a standard bg and some buttons that drops the menu. To solve > this I've added an envvar to disable it. > > Another problem is that elm_menu api is quite barebones, as well as > the appmenu e18 implementation. For instance I don't get a callback > when the "Tabs" menu is activated, thus I can't dynamically populate > it and I have to keep rewriting the whole submenu on title or tabs > changes. > > The menu api and theme can be improved, just need a review on the > patch and if it will get in or not. > > Cheers, > -- > Gustavo Sverzut Barbieri > -------------------------------------- > Mobile: +55 (19) 9225-2202 > Contact: http://www.gustavobarbieri.com.br/contact -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
