Hello, On Wed, Sep 11, 2013 at 11:11 PM, Gustavo Sverzut Barbieri <barbi...@gmail.com> wrote: > On Wed, Sep 11, 2013 at 4:11 AM, Cedric Bail - Enlightenment Git > <no-re...@enlightenment.org> wrote: >> cedric pushed a commit to branch master. >> >> commit cd77853222d1c11d71da4ca9066abe35390dcd5e >> Author: Cedric Bail <cedric.b...@samsung.com> >> Date: Wed Sep 11 16:08:06 2013 +0900 >> >> eo: add eo_childrens_iterator_new(). >> >> The goal would be to replace the smart children list and friends. The >> problem is that they differ in content. Smart children and Eo children >> are >> the same, but Elm children and them differ. If I put this function as a >> virtual, it would be possible to override the list of children and if we >> start using it in Evas render loop, that could result in "weird" >> behavior. > > 1st, as glima pointed out children is already plural form, no need for > trailing "s"
Fix, thanks. > 2nd, I think this may cause a confusion. If one want all the Eo whose > eo_parent_get() is X, they may want to call > eo_children_iterator_new(X), but this virtual may not return that > exact list, but a subset. I don't remember exactly about the Elm case, > but I recall we had cases where one object is bound to another without > being member_add(), in that case eo_children_iterator_new() would > return objects that eo_parent_get(child) != X. Yes, you see my problem. So for the moment it is not a virtual function. The think is that right now we do have many children list: one in Eo, one in Evas smart object, one in Evas Box object, one in Evas Table object and one in Elm object(Actually Edje also has one, but a little bit different). Now I am trying to find where they do match and it is clearly not obvious :-( > I see what you're trying to do, but I don't know if the naming is correct. Open to better idea here. Also I have been looking at adding events on child ADD and DEL, but it is going to be complex. As the children are part of eo.c and not of the base class, I can't be sure that it is actually an object that have an event infrastructure. There is I think two possibility. - Make eo.c check the type of the object and dispatch an event if it is an object inherited from eo base class. - Move the parent code handling into eo base class. Any though on that subject also ? -- Cedric BAIL ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
