On 17/09/13 08:30, Stefan Schmidt wrote: > Hello. > > On 09/17/2013 07:44 AM, Chris Michael - Enlightenment Git wrote: >> devilhorns pushed a commit to branch master. >> >> commit 64bc97c53c5c3772595f9d2321f9e19590d8a477 >> Author: Chris Michael <cp.mich...@samsung.com> >> Date: Mon Sep 16 11:40:30 2013 +0100 >> >> Remove __UNUSED__ from function declaration where parameter is >> actually used. > > This brings an old topic back into my mind. > > Its not the first time we eagerly tagged parameters as unused because > gcc warned about it and later started to use them without removing the > unused label. This has the potential to screw us badly as it is up to > the compiler to decide what to do with the parameter here. > > Given how many callback and other signatures we have with user_data or > other unused parameters we end up with 3630 EINA_UNUSED and even 71 > __UNUSED__ in efl alone. All with the potential to be used at some point > but forgotten to remove the label. > > My proposal would be to use -Wno-unused-parameter in our CFLAGS to > disable this warning and remove all EINA_UNUSED and __UNUSED__ from > parameters. > > I know it has the downside that in the rare case where you add a > parameter to a signature yourself (read: not using an existing function > signature) you might add it and forgot to use it. Which will not > reported as warning in this case. > > In my opinion the risk is higher than the benefit here. > > I expect people to have a different opinion on this and get really angry > if I just start to add the CFLAG and remove all EINA_UNSED from > parameter so I thought I bring it up here to get some opinions. We > normally have plenty of opinions around. :) > > regards > Stefan Schmidt >
First, all I can say is Wow !! One of my commits has actually brought about Constructive criticism for a change :P That being said, I would have to agree with you on this. While (EINA_)UNUSED is nice, it's actual benefit is negligible when people do not (or forget to) remove the UNUSED at a later date when things are used. Potentially leading to the compiler making an incorrect decision. Although, on the other hand I don't see -Wno-unused-parameter as being Ideal either (as you mentioned above with not reported warnings).... On a personal level, I would be ok with either approach. However, if we do stick with (EINA_)UNUSED, then I think that people just need to be more diligent when they modify functions/code. Cheers, dh ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
