On Tue, Sep 17, 2013 at 6:40 AM, Stefan Schmidt <s.schm...@samsung.com> wrote: > Hello. > > As you like to point out problems with mails. No need to CC me, I'm on > the list. :) > > I also know that thunderbird sucks at this but I'm able to do it. :) > > On 09/17/2013 10:21 AM, Tom Hacohen wrote: >> On 17/09/13 08:30, Stefan Schmidt wrote: >>> Hello. >>> >>> On 09/17/2013 07:44 AM, Chris Michael - Enlightenment Git wrote: >>>> devilhorns pushed a commit to branch master. >>>> >>>> commit 64bc97c53c5c3772595f9d2321f9e19590d8a477 >>>> Author: Chris Michael <cp.mich...@samsung.com> >>>> Date: Mon Sep 16 11:40:30 2013 +0100 >>>> >>>> Remove __UNUSED__ from function declaration where parameter is >>>> actually used. >>> >>> This brings an old topic back into my mind. >>> >>> Its not the first time we eagerly tagged parameters as unused because >>> gcc warned about it and later started to use them without removing the >>> unused label. This has the potential to screw us badly as it is up to >>> the compiler to decide what to do with the parameter here. >> >> I don't know much about the exact implementation details of GCC, but I >> find it very unlikely that GCC is allowed, or will ever actually do >> anything about a *used* variable that is marked as unused. That just >> sounds too crazy to be true. So I don't think we'll ever get screwed. > > I have in the back of my mind that we already screwed by this. I don't > have the details at hand so I can't proof it. > > If I ever run into this problem with efl I will bill you the number of > hours I had to work it out. Could easily be days for such a thing. :)
Most likely the problem you remember is regarding the pure or const attributes, not the unused. If you declare the function as pure and then in reality it isn't, bad things will happen depending on the optimization level because the compiler may reuse a previous return value instead of calling the function again. I remember fixing one problem like this in E or EFL some years ago. Lucas De Marchi ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
