On Thu, 29 May 2014 10:00:23 -0400 Michael Blumenkrantz
<michael.blumenkra...@gmail.com> said:

> On Thu, 29 May 2014 05:45:16 -0700
> Carsten Haitzler <ras...@rasterman.com> wrote:
> 
> > raster pushed a commit to branch master.
> > 
> > http://git.enlightenment.org/core/enlightenment.git/commit/?id=1f8975d5461f8e274ca1431c675903e3578803e8
> > 
> > commit 1f8975d5461f8e274ca1431c675903e3578803e8
> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> > Date:   Thu May 29 21:45:48 2014 +0900
> > 
> >     stacking - fix stacking after/before fullscreening
> >     
> >     input events were broken due to stacking not being maintained for the
> >     actual windows going to/from fullscreen
> > ---
> >  src/bin/e_client.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/bin/e_client.c b/src/bin/e_client.c
> > index 932ba22..0917dca 100644
> > --- a/src/bin/e_client.c
> > +++ b/src/bin/e_client.c
> > @@ -3626,6 +3626,7 @@ e_client_fullscreen(E_Client *ec, E_Fullscreen policy)
> >       }
> >     e_hints_window_size_set(ec);
> >  
> > +   evas_object_data_set(ec->frame, "client_restack", (void *)1);
> >     ec->saved.layer = ec->layer;
> >     if (!e_config->allow_above_fullscreen)
> >       evas_object_layer_set(ec->frame, E_LAYER_CLIENT_FULLSCREEN);
> > 
> 
> This is 100% wrong, even if it does fix some issue. client_restack should
> only be set internally; the bug you are experiencing is elsewhere.

fullscreen sets layer. restack cb gets called. restack cb checks if this data
key exists and if so, fixes stacking of the original window. without setting
this key the whole code to handle restacking falls over basically every time
layer is set... so the other problem, if there is one is either checking for
the key at all in the cb, or a massive problem all over the code where stacking
is broken. and i have noticed that stacking regularly is wrong big-time. i
click on something that visually is there and my click goes elsewhere. in the
case i was looking at i dumped the window tree and indeed stacking in the
window tree did not match that of the visual setup (the visual was right).

-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
Time is money. Stop wasting it! Get your web API in 5 minutes.
www.restlet.com/download
http://p.sf.net/sfu/restlet
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to