On 02/10/14 13:37, Cedric BAIL wrote: > On Thu, Oct 2, 2014 at 12:31 PM, Tom Hacohen <tom.haco...@samsung.com> wrote: >> On 02/10/14 11:20, Daniel Kolesa wrote: >>> 2014-10-02 11:12 GMT+01:00 Daniel Zaoui <daniel.za...@samsung.com>: >>>> Hi D5, >>>> >>>> Didn't we speak about having automatic tests to be sure it works as >>>> expected? And don't tell me Lua checks it ;-) >>>> >>> >>> I don't really think a test is necessary here, considering that whether it >>> works or not is immediately visible from whether the generator creates a >>> working output (for any eo file). If it didn't work, stuff wouldn't compile. >> >> >> I strongly disagree. Covering all the functions, even the dead simple >> ones like this, even if not important for testing the code is important >> for the following three reasons: > > You know that if it is executed during compilation stage it does > account in our test coverage ? Just saying ;-) >
I didn't know that, but even if that's the case, it's not done consistently. When you re-run locv-check it clears the old info and generates a new report. During this run the lua stuff won't be run at all (unless he adds lua tests...). Anyhow, I rather have proper testing than a house of cards hack. :) -- Tom. ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
