Hermet, You are 1,000% correct here !!
elm_win_window_id_get() should be returning the ecore_wl_window_id_get(); An obvious mistake in the code :( I am sure at time of writing that elm function, I had a reason for using surface_id (but since I am old, I don't remember what that reason was) ;) Returning ecore_wl_window_id_get() would be more inline with what we are expecting there and would allow use of ecore_wl functions also. Please feel free to patch/fix...and Thank You for spotting that !! Cheers, dh On 03/26/2015 10:12 AM, ChunEon Park wrote: > Hi, > > I found a problem at elm_win_window_id_get() API which returns the > wayland surface id (actually proxy id). > > Problem is, our Ecore Wayland APIs requires Ecore_Wl_Window handle > that is not matched with surface id. > > just in case Ecore X, we can use the X ID generally, but in case of > the wayland, we cannot. > > Worse case is, even app can not call the wayland client apis directly > with the surface id since wayland client interfaces requires the > surface itself handle(wl_surface *) but not surface id (proxy id). > > I don't know your intention (or is it mistake?), at this moment. > > But I think it should return the window id with > ecore_wl_window_id_get(), rather than elm_wl_window_surface_id_get() > so that people get the wl_surface or Ecore_Wl_Wayland handle from the > window id. > > What do you think? > > ------------------------------------ -Regards, Hermet- > ------------------------------------------------------------------------------ > > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your > hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials and more. > Take a look and join the conversation now. > http://goparallel.sourceforge.net/ > _______________________________________________ enlightenment-devel > mailing list enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
