Had to revert it as it broke some logic on the E side of things On 04/17/2015 03:16 AM, ChunEon Park wrote: > does it? or reverted? > > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Christopher Michael"<cpmich...@osg.samsung.com> > To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2015-04-17 (금) 00:10:08 > Subject: Re: [E-devel] strange elm_win_window_id_get() please read devilhorn. > > Fixed with 257452f46d344b64d611aa5 > > Thank you for reporting :) > > On 03/26/2015 11:05 AM, Christopher Michael wrote: >> Hermet, >> >> You are 1,000% correct here !! >> >> elm_win_window_id_get() should be returning the ecore_wl_window_id_get(); >> >> An obvious mistake in the code :( I am sure at time of writing that elm >> function, I had a reason for using surface_id (but since I am old, I >> don't remember what that reason was) ;) >> >> Returning ecore_wl_window_id_get() would be more inline with what we are >> expecting there and would allow use of ecore_wl functions also. >> >> Please feel free to patch/fix...and Thank You for spotting that !! >> >> Cheers, >> dh >> >> On 03/26/2015 10:12 AM, ChunEon Park wrote: >>> Hi, >>> >>> I found a problem at elm_win_window_id_get() API which returns the >>> wayland surface id (actually proxy id). >>> >>> Problem is, our Ecore Wayland APIs requires Ecore_Wl_Window handle >>> that is not matched with surface id. >>> >>> just in case Ecore X, we can use the X ID generally, but in case of >>> the wayland, we cannot. >>> >>> Worse case is, even app can not call the wayland client apis directly >>> with the surface id since wayland client interfaces requires the >>> surface itself handle(wl_surface *) but not surface id (proxy id). >>> >>> I don't know your intention (or is it mistake?), at this moment. >>> >>> But I think it should return the window id with >>> ecore_wl_window_id_get(), rather than elm_wl_window_surface_id_get() >>> so that people get the wl_surface or Ecore_Wl_Wayland handle from the >>> window id. >>> >>> What do you think? >>> >>> ------------------------------------ -Regards, Hermet- >>> ------------------------------------------------------------------------------
------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
