On Wed, 18 Nov 2015 13:20:14 -0600 Jeff Hoogland <jeffhoogl...@gmail.com> said:
> Good to know the theme API still is allowed to break release to release. > > Guess I'll stick with 1.15 for awhile so I don't have to worry about > chasing down issues with each release. no one said it was allowed to break and no single commit to toolbar code between 1.15 and 1.16 goes explicitly breaking any theme api - go read the commits and their diffs. we emit more signals than before - but we didn't remove or rename any. nor any swallow parts, text part names etc. etc. before you go making accusations - make sure you have at least some proof. the ONLY change to the default theme regarding toolbar was a bugfix in the default theme (yes - it has BUGS - funny that, and then you copy the theme, do your own, and very likely DON'T fix corresponding bugs... but let's not dwell on that)... let's go grab some.... facts. only 2 commits happened to default theme between 1.15 a 1.16 affecting toolbar. ed948dc90829704860d355cc17b7da201d744719 by mike that simply removed a line that was a default value anyway. 740cc0751807bb0c0bbb393d6e0d2e1588eb0678 that FIXED ZERO sized items. not zero sized icons tho... it makes item_centered just an alias instead of an inherited part (saves space as the inherit made no changes) and it fixes the item_horizontal which is not used in your app. it is what is used in terminology tho... so no changes in default theme related to your issue. so lets look at code. 1.15 came out august 5. so: git diff -u --color src/lib/elm_toolbar.c all commits newer than 6008c2c3867e3198d468b66d703aa39ee21445a5 ... go read the diffs. find me one that goes brazenly breaking theme api. go on. find it. none. the icon_size data field is used nowhere in default theme - so changes to making it apply elm scale wouldn't break anything as you'd have to be setting scale to 0 or have an infinite base scale for this to change the value, so if anything you already had it and it returned 0. so it can't sensibly be that. getting focus? no - not related to icon sizing. sep 12 look - handling 0 item size ... we emitted the incorrect signals to items i fixed it. with some extra emits to explicitly make icon visible (not your problem unless your theme is hiding icons when the signal says to make them visible... is it? that'd be a theme bug) and of course emitting signals if there is no icon (check code that is patched... the first if () is if (it->icon) ...) so it's handling the "i have no icon" case as well as the "i have no label" case which it didn't before. sep 15 - other focus changes. not icon or theme. sep 23 then select mode changes, not icon/theme. oct 2 - then atspi changes only doing things when atspi mode is on. oct 12 - then a toolbar shrink mode change only applies if you have no items... not your case. now oct 15 - some moving of sizing evaluation to defer it to later to save cpu time. not a theme api break. now some more atspi stuff - not theme or icons... now oct 19 some more limiting of re-calcs to save cpu time nov 5 - atspi stuff again then 1.16 release. look. there's a reason i'm snapping back here. if you make an accusation like we are happily allowing theme api to break (and we care and actually try not to) then at least have something to back it up. show me a commit, change etc. that is obviously some theme api break we should have caught and not done? show me. i've BOTHERED to read commits and found nothing obvious to hunt. whatever has happened will take far more time and poking around and we have no idea WHAT the problem is. it could quite easily be simply a theme bug in your theme that now just HAPPENS to be triggered. it could easily be that it got away by LUCK before, not by design. much like if your distro booted right to a root prompt before and maybe now has decided to force a login instead? if maybe before i did char *x = malloc(10); free(x); *x = 1; and it WORKED before and NOW crashes because it's now stricter and actually fails when you do something wrong. i don't know, BUT i can say this. the toolbar icons are elm icon widgets. they are swallowed. unless they set a minimum size of their own - they will very likely size down to 0 unless the toolbar itself is forcibly expanded to be bigger so there is space for icons to grow. icon size can be determined by theme and it can be overridden by api. elm icon itself doesn't determine its own min size at all. in fact i'm kind of baffled by icons are not 0 sized by default. it seems by luck they are not - but what luck, i don't know so jeff - please at least dig a little bit before making unsubstantiated accusations. > On Sat, Nov 14, 2015 at 8:21 PM, Jeff Hoogland <jeffhoogl...@gmail.com> > wrote: > > > Opened a ticket -> https://phab.enlightenment.org/T2848 > > > > On Sat, Nov 14, 2015 at 8:11 PM, Simon Lees <si...@simotek.net> wrote: > > > >> > >> > >> On 11/15/2015 12:31 PM, Jeff Hoogland wrote: > >> > This seems to be theme related, icons appear as expected in the default > >> > theme on Elementary 1.16 > >> > > >> > Guess I'll open a bug report. > >> I can confirm this on a older theme i have, the ones I merged with dark > >> in the last month or so seem fine. > >> > >> > On Sat, Nov 14, 2015 at 7:54 PM, Jeff Hoogland <jeffhoogl...@gmail.com> > >> > wrote: > >> > > >> >> Anyone else seeing an issue with images on toolbars with 1.16? ePad and > >> >> ePhoto are both missing icons on their tool bar here with the 1.16 > >> bindings > >> >> VS 1.15.1 > >> >> > >> >> Screenshot: > >> >> > >> >> http://i.imgur.com/wmuiJYB.png > >> >> > >> >> Exact same ePad code, the one on the right is using elementary 1.15.1 > >> the > >> >> one on the left is using 1.16 > >> >> > >> >> On Mon, Nov 9, 2015 at 5:09 AM, Stefan Schmidt <ste...@osg.samsung.com > >> > > >> >> wrote: > >> >> > >> >>> = Enlightenment Foundation Libraries 1.16 and Friends are Out = > >> >>> > >> >>> After three months of development work we are proud to announce the > >> >>> release of > >> >>> version 1.16 of the EFL, Elementary, Evas Generic Loaders and Emotion > >> >>> Generic > >> >>> Players. In these 12 weeks we got over 700 commits from 58 authors in > >> >>> EFL alone. > >> >>> We slowed down a bit from last release (by around 300 commits). > >> >>> Elementary has another > >> >>> 382 commits by 52 authors. Great job everyone! Some highlights are > >> >>> listed below. > >> >>> > >> >>> == Download == > >> >>> > >> >>> http://download.enlightenment.org/rel/libs/efl/efl-1.16.0.tar.gz > >> >>> 35af0783d6dd87ebb435c46fd662ef5a648510d74fb6dc6540a3165c9b221e50 > >> >>> > >> >>> > >> >>> > >> http://download.enlightenment.org/rel/libs/elementary/elementary-1.16.0.tar.gz > >> >>> 18b1f2d55af46840d0a9477a615d0c5a033b24f06d8fcf539da33aa5db357bd0 > >> >>> < > >> http://download.enlightenment.org/rel/libs/elementary/elementary-1.16.0.tar.gz18b1f2d55af46840d0a9477a615d0c5a033b24f06d8fcf539da33aa5db357bd0 > >> > > >> >>> > >> >>> > >> >>> > >> http://download.enlightenment.org/rel/libs/emotion_generic_players/emotion_generic_players-1.16.0.tar.gz > >> >>> cbb34faa0b6d114a3a0a5e4451f03f8423c5a48fd3fe9a6c6ecdfa65f4083c80 > >> >>> < > >> http://download.enlightenment.org/rel/libs/emotion_generic_players/emotion_generic_players-1.16.0.tar.gzcbb34faa0b6d114a3a0a5e4451f03f8423c5a48fd3fe9a6c6ecdfa65f4083c80 > >> > > >> >>> > >> >>> > >> >>> > >> http://download.enlightenment.org/rel/libs/evas_generic_loaders/evas_generic_loaders-1.16.0.tar.gz > >> >>> 0928a675bca95f7929626550eae85559d296b33b3ecc111aece4744601369a1a > >> >>> < > >> http://download.enlightenment.org/rel/libs/evas_generic_loaders/evas_generic_loaders-1.16.0.tar.gz0928a675bca95f7929626550eae85559d296b33b3ecc111aece4744601369a1a > >> > > >> >>> > >> >>> ---- > >> >>> > >> >>> = What's New = > >> >>> > >> >>> Even if we had only three months a lot has happened during the 1.16 > >> >>> release cycle. > >> >>> We only cover some highlights here. For the full list please look at > >> the > >> >>> NEWS files > >> >>> if you are interested in the details. As usual we have been working on > >> >>> fixing bugs, > >> >>> optimising our code for speed and memory footprint and adding new > >> >>> features. > >> >>> Below we describe just some highlights and by no means provide a full > >> >>> list. > >> >>> > >> >>> = EFL = > >> >>> > >> >>> == Wayland == > >> >>> The focus of work on our wayland areas have been stabilisation and > >> >>> filling of gaps for the upcoming E20 release. To make 1.16 a solid > >> base > >> >>> for it work has been gone to make the evas drm engine more solid and > >> >>> adding support for things like adjusting keyboard repeat and rate > >> delay, > >> >>> etc > >> >>> > >> >>> == Evas GL == > >> >>> Besides some normal optimisation evas GL got support for the new > >> partial > >> >>> update extension. > >> >>> > >> >>> == Eina == > >> >>> To aid debugging and tooling infrastructure eina thread does now > >> support > >> >>> setting thread names and many internal threads are already named. > >> >>> > >> >>> == Eo (BETA) == > >> >>> A lot of optimisation, memory as well as CPU time, has been gone into > >> EO > >> >>> this time. Initially we hoped to declare EO stable after this > >> >>> development cycle, but we need to postpone this for at least another > >> >>> cycle as some more optimisation are being planned which might break > >> ABI. > >> >>> > >> >>> == Elementary == > >> >>> We improved our thumbscroll finger scrolling to be smoother and worked > >> >>> on various parts of focus handling of items. On the ATSPI front we > >> added > >> >>> a translation domain for name and description as well as support for > >> the > >> >>> org.a11y.atspi.Collection interface. > >> >>> > >> >>> ---- > >> >>> > >> >>> = Statistics = > >> >>> > >> >>> == EFL == > >> >>> (git log --pretty=oneline v1.15.0..v1.16.0 | wc -l) > >> >>> Number of commits: 701 > >> >>> > >> >>> (git shortlog -ns v1.15.0..v1.16.0 | wc -l) > >> >>> Number of authors: 58 > >> >>> > >> >>> (git diff --stat v1.15.0..v1.16.0 | tail -1) > >> >>> 546 files changed, 52121 insertions(+), 24088 deletions(-) > >> >>> > >> >>> == Elementary == > >> >>> (git log --pretty=oneline v1.15.0..v1.16.0 | wc -l) > >> >>> Number of commits: 382 > >> >>> > >> >>> (git shortlog -ns v1.15.0..v1.16.0 | wc -l) > >> >>> Number of authors: 52 > >> >>> > >> >>> (git diff --stat v1.15.0..v1.16.0 | tail -1) > >> >>> 305 files changed, 23711 insertions(+), 15250 deletions(-) > >> >>> > >> >>> ---- > >> >>> > >> >>> =Building and Dependencies= > >> >>> > >> >>> If you have an existing EFL or Elementary install, you may wish to > >> >>> delete its header files and libraries before compiling and installing > >> to > >> >>> avoid possible conflicts during compilation. If you are compiling the > >> >>> above, please compile them in the following order: > >> >>> > >> >>> efl > >> >>> elementary > >> >>> emotion_generic_players > >> >>> evas_generic_loaders > >> >>> Please refer to the respective README files in each release for a full > >> >>> list of dependencies, explanations on configure flags and other > >> relevant > >> >>> information (Just scroll down to see the README already displayed > >> nicely). > >> >>> > >> >>> EFL > >> >>> Elementary > >> >>> Emotion Generic Players > >> >>> Evas Generic Loaders > >> >>> Recommended dependencies are for all of the above are: > >> >>> > >> >>> bullet > >> >>> libpng > >> >>> libjpeg > >> >>> gstreamer (1.x) (ensure you have all the gstreamer codecs you > >> need/want.) > >> >>> zlib > >> >>> luajit (optional lua 5.1 or 5.2) > >> >>> libtiff > >> >>> openssl > >> >>> curl > >> >>> dbus > >> >>> libc > >> >>> fontconfig > >> >>> freetype2 > >> >>> fribidi > >> >>> libpulse > >> >>> libsndfile > >> >>> libx11 > >> >>> libxau > >> >>> libxcomposite > >> >>> libxdamage > >> >>> libxdmcp > >> >>> libxext > >> >>> libxfixes > >> >>> libxinerama > >> >>> libxrandr > >> >>> libxrender > >> >>> libxss > >> >>> libxtst > >> >>> libxcursor > >> >>> libxp > >> >>> libxi (2.2 or newer) > >> >>> libgl (opengl/glx or opengl-es2/egl) > >> >>> giflib > >> >>> util-linux (limbount + libblkid) > >> >>> systemd / libudev > >> >>> harfbuzz > >> >>> systemd > >> >>> libwebp > >> >>> vlc (libvlc) > >> >>> poppler > >> >>> libraw > >> >>> libspectre > >> >>> librsvg > >> >>> > >> >>> It is suggested you add the following options when building the EFL to > >> >>> get a better experience: > >> >>> --enable-xinput22 \ > >> >>> --enable-multisense \ > >> >>> --enable-systemd \ > >> >>> --enable-image-loader-webp \ > >> >>> --enable-harfbuzz > >> >>> > >> >>> On linux to get framebuffer support you may want to also do: > >> >>> --enable-fb > >> >>> --disable-tslib > >> >>> > >> >>> If you want wayland support also add: > >> >>> --enable-wayland > >> >>> > >> >>> At runtime if you want thumbnailing for DOC/PPT/XLS etc. files also > >> >>> provide: > >> >>> libreoffice > >> >>> > >> >>> > >> >>> > >> >>> > >> >>> > >> ------------------------------------------------------------------------------ > >> >>> Presto, an open source distributed SQL query engine for big data, > >> >>> initially > >> >>> developed by Facebook, enables you to easily query your data on > >> Hadoop in > >> >>> a > >> >>> more interactive manner. Teradata is also now providing full > >> enterprise > >> >>> support for Presto. Download a free open source copy now. > >> >>> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140 > >> >>> _______________________________________________ > >> >>> enlightenment-devel mailing list > >> >>> enlightenment-devel@lists.sourceforge.net > >> >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >>> > >> >> > >> >> > >> >> -- > >> >> ~Jeff Hoogland <http://jeffhoogland.com/> > >> >> My Projects on GitHub <https://github.com/JeffHoogland> > >> >> > >> > > >> > > >> > >> > >> > >> ------------------------------------------------------------------------------ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > > > -- > > ~Jeff Hoogland <http://jeffhoogland.com/> > > My Projects on GitHub <https://github.com/JeffHoogland> > > > > > > -- > ~Jeff Hoogland <http://jeffhoogland.com/> > My Projects on GitHub <https://github.com/JeffHoogland> > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
