On Tue, Jan 26, 2016 at 3:44 PM, Felipe Magno de Almeida <[email protected]> wrote: > On Tue, Jan 26, 2016 at 12:59 PM, Stefan Schmidt <[email protected]> > wrote: >> Hello. > > [snip] > >>>> Efl_Model_Common.h >>>> efl_model_error_notify ( Efl_Model_Base* model ) >>>> efl_model_list_slice ( Eina_List* list, unsigned int start, unsigned int >>>> count ) >>>> efl_model_load_set ( Efl_Model_Base* model, Efl_Model_Load* load, enum >>>> Efl_Model_Load_Status status ) >>>> efl_model_property_changed_notify ( Efl_Model_Base* model, char const* >>>> property ) >>>> efl_model_property_invalidated_notify ( Efl_Model_Base* model, char >>>> const* property ) >>>> efl_model_value_struct_description_free ( Eina_Value_Struct_Desc* desc ) >>>> efl_model_value_struct_description_new ( unsigned int member_count, >>>> Efl_Model_Value_Struct_Member_Setup_Cb setup_cb, void* data ) >>> This should still be under BETA flag, isn't that the case ? To me the >>> header is completely protected by the BETA flag. >>> >> >> Hmm, do you mean because it is included behind a #ifdef >> EFL_BETA_API_SUPPORT in Efl.h? >> >> The Efl_Model_Common.h has no BETA_API guards at all and it is shipped >> which means anyone can include this without having to define the >> BETA_API in their app. >> I think some guards inside Efl_Model_Common.h are also needed. > > Should efl_model_base.eo.h be marked as beta as well? It doesn't > seem to be possible to define a whole class @beta in Eolian. But > it also gets shipped and can be directly included.
This is true for all Efl* header. I don't think it is a real problem as they would fail to compile without proper difficult to get right include. We do only support direct include of the main header file and nothing else. If someone does something else. To bad for them, no ? -- Cedric BAIL ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
