I don't think this is a reasonable thing to enable at all presently.
Enlightenment output is completely unusable, and I've had to revert the
commit entirely in order to continue making any progress with debugging.

Anyone trying to run Enlightenment after this commit will very quickly find
their disks full.

On Thu, Feb 18, 2016 at 12:33 PM Cedric BAIL <moa.blueb...@gmail.com> wrote:

> On Feb 18, 2016 07:59, "Tom Hacohen" <t...@stosb.com> wrote:
> >
> > tasn pushed a commit to branch master.
> >
> >
>
> http://git.enlightenment.org/core/efl.git/commit/?id=ec2f92e35f5a0836933d82b6b7f518a1d7550afc
> >
> > commit ec2f92e35f5a0836933d82b6b7f518a1d7550afc
> > Author: Tom Hacohen <t...@stosb.com>
> > Date:   Thu Feb 18 15:53:40 2016 +0000
> >
> >     Eo: Print an ERR when deleting an object with data refs.
> > ---
> >  src/lib/eo/eo_private.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/src/lib/eo/eo_private.h b/src/lib/eo/eo_private.h
> > index 869745c..f3ec7db 100644
> > --- a/src/lib/eo/eo_private.h
> > +++ b/src/lib/eo/eo_private.h
> > @@ -245,12 +245,11 @@ _eo_free(_Eo_Object *obj)
> >  {
> >     _Eo_Class *klass = (_Eo_Class*) obj->klass;
> >
> > -#ifdef EO_DEBUG
> >     if (obj->datarefcount)
> >       {
> >          ERR("Object %p data still referenced %d time(s).", obj,
> obj->datarefcount);
>
> I think we can safely go with a critical error here as this is likely going
> to have some big bug hidden somewhere else. Also when in debug we have
> additional information like where that reference was taken, I think it
> would be nice to display too.
>
> >       }
> > -#endif
> > +
> >     _eo_id_release((Eo_Id) _eo_id_get(obj));
> >
> >     eina_spinlock_take(&klass->objects.trash_lock);
> >
> > --
> >
> >
> >
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to