On 18/02/16 19:21, Mike Blumenkrantz wrote: > On Thu, Feb 18, 2016 at 2:13 PM Tom Hacohen <t...@osg.samsung.com> wrote: > >> On 18/02/16 19:06, Mike Blumenkrantz wrote: >>> I don't think this is a reasonable thing to enable at all presently. >>> Enlightenment output is completely unusable, and I've had to revert the >>> commit entirely in order to continue making any progress with debugging. >>> >>> Anyone trying to run Enlightenment after this commit will very quickly >> find >>> their disks full. >> >> The problem is that this is probably related to *real* issues, like >> https://phab.enlightenment.org/T3156 and we should fix them. >> >> I understand it's bad, that's why I sent this email in the first place, >> but these issues need fixing. I think and hope it'll be easy to fix >> them, but I'm not 100% sure about that or the right course of action. >> >> -- >> Tom >> > > I support fixing issues--I suspect everyone does. Enabling something like > this may reveal "real" issues, as you've put it, but it also creates a new > one in the process, and the new issue is far more severe than any other > issue which was being hidden. >
That might be the case, that's why we are here, talking about it. > I realize you don't use Enlightenment, but please test with it before > enabling things like this: saying "I think and hope it'll be easy to fix > [the issues]" while also filling the hard drives of anyone who updates is > not helpful to anyone, least of all people who are trying to fix issues. I didn't think this would cause an issue. When I realised it might, I sent this email. As I said, I didn't know about the adverse implications (e.g. filling hard drives), that's why I sent an email to the ML to see if there were any issues. We found some, so I reverted it for now. As for your notion that I should test it with enlightenment: it's too much of a hassle to do it, and I think is a bit unreasonable, the same way we don't test other applications that use the efl. With that being said, even if I was testing enlightenment on a regular basis, I wouldn't have tested this one because it's such a minor change, and even if I had, I wouldn't have discovered this one, because of the nature of the issue (file getting big). > > >> >>> >>> On Thu, Feb 18, 2016 at 12:33 PM Cedric BAIL <moa.blueb...@gmail.com> >> wrote: >>> >>>> On Feb 18, 2016 07:59, "Tom Hacohen" <t...@stosb.com> wrote: >>>>> >>>>> tasn pushed a commit to branch master. >>>>> >>>>> >>>> >>>> >> http://git.enlightenment.org/core/efl.git/commit/?id=ec2f92e35f5a0836933d82b6b7f518a1d7550afc >>>>> >>>>> commit ec2f92e35f5a0836933d82b6b7f518a1d7550afc >>>>> Author: Tom Hacohen <t...@stosb.com> >>>>> Date: Thu Feb 18 15:53:40 2016 +0000 >>>>> >>>>> Eo: Print an ERR when deleting an object with data refs. >>>>> --- >>>>> src/lib/eo/eo_private.h | 3 +-- >>>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>>> >>>>> diff --git a/src/lib/eo/eo_private.h b/src/lib/eo/eo_private.h >>>>> index 869745c..f3ec7db 100644 >>>>> --- a/src/lib/eo/eo_private.h >>>>> +++ b/src/lib/eo/eo_private.h >>>>> @@ -245,12 +245,11 @@ _eo_free(_Eo_Object *obj) >>>>> { >>>>> _Eo_Class *klass = (_Eo_Class*) obj->klass; >>>>> >>>>> -#ifdef EO_DEBUG >>>>> if (obj->datarefcount) >>>>> { >>>>> ERR("Object %p data still referenced %d time(s).", obj, >>>> obj->datarefcount); >>>> >>>> I think we can safely go with a critical error here as this is likely >> going >>>> to have some big bug hidden somewhere else. Also when in debug we have >>>> additional information like where that reference was taken, I think it >>>> would be nice to display too. >>>> >>>>> } >>>>> -#endif >>>>> + >>>>> _eo_id_release((Eo_Id) _eo_id_get(obj)); >>>>> >>>>> eina_spinlock_take(&klass->objects.trash_lock); >>>>> >>>>> -- >>>>> >>>>> >>>>> >>>> >>>> >> ------------------------------------------------------------------------------ >>>> Site24x7 APM Insight: Get Deep Visibility into Application Performance >>>> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >>>> Monitor end-to-end web transactions and take corrective actions now >>>> Troubleshoot faster and improve end-user experience. Signup Now! >>>> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> enlightenment-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>> >>> >> ------------------------------------------------------------------------------ >>> Site24x7 APM Insight: Get Deep Visibility into Application Performance >>> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >>> Monitor end-to-end web transactions and take corrective actions now >>> Troubleshoot faster and improve end-user experience. Signup Now! >>> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >> >> >> >> ------------------------------------------------------------------------------ >> Site24x7 APM Insight: Get Deep Visibility into Application Performance >> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >> Monitor end-to-end web transactions and take corrective actions now >> Troubleshoot faster and improve end-user experience. Signup Now! >> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
