2016-04-28 8:36 GMT+02:00 이상현 <dltkdgus1...@gmail.com>: > Hello, Mr Andreoli. >
hehe, "Mr Andreoli" is way too formal you can just call me Dave, we are friendly and informal here :) > > Sorry again for my pending reply. > The patch wasn't test for every cases, > so I'll revert it now. > > And if you don't mind, please share us the problem after this patch > updated. > Sure I will, for now you can just test as I explained in previous mail (ITEM_NUM = 30), that is probably really close to my use case. My usage in epymc is this (something like paginating results): 1. I populate the genlist with the first 20 items (fetched from an online source) 2. append a "Load more items" item 3. when user choose the last item I download next 20 items and bring-in the "Load more items" to the top so that the new items are visible. Currently this do not work at all (it was used to work with efl < 1.17) but with your patch this become really strange: the bring-in scrolling take place only after I move the selection to another item. Thanks for taking care of this, it is indeed a bug that need to be solved > > Sorry for your inconvenience and thanks again. > > Regards, > Sanghyeon Lee > 2016. 4. 28. 오전 5:28에 "Davide Andreoli" <d...@gurumeditation.it>님이 작성: > > > 2016-04-20 19:56 GMT+02:00 Davide Andreoli <d...@gurumeditation.it>: > > > > > 2016-04-19 7:01 GMT+02:00 Jee-Yong Um <jc9...@samsung.com>: > > > > > >> sanghyeonlee pushed a commit to branch master. > > >> > > >> > > >> > > > http://git.enlightenment.org/core/efl.git/commit/?id=87b12327c3356ac8233cb5a08260625221239153 > > >> > > >> commit 87b12327c3356ac8233cb5a08260625221239153 > > >> Author: Jee-Yong Um <jc9...@samsung.com> > > >> Date: Tue Apr 19 13:59:59 2016 +0900 > > >> > > >> genlist: scroll to item when calc is done > > >> > > >> Summary: > > >> If elm_genlist_item_bring_in() is called immediately after > appending > > >> item, genlist will not scroll to the last one but stop in the > > middle. > > >> This patch blocks genlist from scrolling to not calculated item. > > >> > > >> Test Plan: > > >> 1. Uncompress attached file > > >> 2. make > > >> 3. ./test > > >> > > > > > > This is somehow wrong, in your test just change ITEM_NUM to 30 to see > > > that it is not working anymore, please give a look into this, it also > > > seems to > > > create some other unwanted side effect in some of my apps. > > > > > > > Hey man, no reply after a full week :( > > > > THIS IS REALLY UNACCEPTABLE !!!! > > > > If you made a commit you MUST follow this list and react asap to > > question/suggestions/whatever from other people, it's the basic rule of > > collaboration. > > > > I WILL REVERT THIS COMMIT IF I WILL NOT GET A REPLY SOON > > > > (probably the author is not reading this message, so I have to ask > someone > > near him to alert about this situation) > > > > > > > > > > > > > > >> > > >> Reviewers: cedric, SanghyeonLee > > >> > > >> Reviewed By: SanghyeonLee > > >> > > >> Subscribers: jpeg > > >> > > >> Differential Revision: https://phab.enlightenment.org/D3861 > > >> --- > > >> src/lib/elementary/elm_genlist.c | 3 +++ > > >> 1 file changed, 3 insertions(+) > > >> > > >> diff --git a/src/lib/elementary/elm_genlist.c > > >> b/src/lib/elementary/elm_genlist.c > > >> index f204537..1e8ec97 100644 > > >> --- a/src/lib/elementary/elm_genlist.c > > >> +++ b/src/lib/elementary/elm_genlist.c > > >> @@ -582,6 +582,9 @@ _item_scroll(Elm_Genlist_Data *sd) > > >> dw = it->item->block->w; > > >> dh = oh; > > >> > > >> + // hold on scrolling to item until block size calculation is > > finished. > > >> + if (dw < 1) return; > > >> + > > >> switch (sd->scroll_to_type) > > >> { > > >> case ELM_GENLIST_ITEM_SCROLLTO_TOP: > > >> > > >> -- > > >> > > >> > > >> > > > > > > > > ------------------------------------------------------------------------------ > > Find and fix application performance issues faster with Applications > > Manager > > Applications Manager provides deep performance insights into multiple > > tiers of > > your business applications. It resolves application problems quickly and > > reduces your MTTR. Get your free trial! > > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > Find and fix application performance issues faster with Applications > Manager > Applications Manager provides deep performance insights into multiple > tiers of > your business applications. It resolves application problems quickly and > reduces your MTTR. Get your free trial! > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
