2016-06-05 10:48 GMT+02:00 Tom Hacohen <t...@osg.samsung.com>: > Hm... we don't do "if dependencies are found" any more... This should be > reverted. > > The point of not having magic is not having magic. We want things to > explicitly fail when deps are missing. Not implicitly disabled. >
Ok, then, instead of reverting, I suggest to make the build fail if dependencies are not found (unless explicitly disabled). Is this ok for you? > > -- > Tom. > > On 04/06/16 20:45, Dave Andreoli wrote: > > davemds pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=e21d357adf9b223659c4595bf4483a3111f44c65 > > > > commit e21d357adf9b223659c4595bf4483a3111f44c65 > > Author: Dave Andreoli <d...@gurumeditation.it> > > Date: Sat Jun 4 21:45:28 2016 +0200 > > > > Enable evas loaders by default, if dependencies are found > > > > I really cannot see why we should require to use --enable-feature on > those, they should be safe. > > --- > > configure.ac | 50 +++++++++++++++++++++++++++++++++++++------------- > > 1 file changed, 37 insertions(+), 13 deletions(-) > > > > diff --git a/configure.ac b/configure.ac > > index b0ec1a2..9712945 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -2809,27 +2809,51 @@ EFL_ADD_FEATURE([EVAS], [hyphen]) > > > > #### Generic backend > > > > -### Option to turn on generic loader for evas > > -want_poppler="no" > > -want_spectre="no" > > -want_libraw="no" > > -want_rsvg="no" > > +### Options to turn off generic loaders for evas > > > > AC_ARG_ENABLE([poppler], > > - [AC_HELP_STRING([--enable-poppler], [enable poppler support > @<:@default==disabled@:>@])], > > - [want_poppler=$enableval]) > > + [AS_HELP_STRING([--disable-poppler],[disable pdf support. > @<:@default=enabled@:>@])], > > + [ > > + if test "x${enableval}" = "xyes" ; then > > + want_poppler="yes" > > + else > > + want_poppler="no" > > + fi > > + ], > > + [want_poppler="yes"]) > > > > AC_ARG_ENABLE([spectre], > > - [AC_HELP_STRING([--enable-spectre], [enable spectre support > @<:@default==disabled@:>@])], > > - [want_spectre=$enableval]) > > + [AS_HELP_STRING([--disable-spectre],[disable postscript support. > @<:@default=enabled@:>@])], > > + [ > > + if test "x${enableval}" = "xyes" ; then > > + want_spectre="yes" > > + else > > + want_spectre="no" > > + fi > > + ], > > + [want_spectre="yes"]) > > > > AC_ARG_ENABLE([libraw], > > - [AC_HELP_STRING([--enable-libraw], [enable libraw support > @<:@default==disabled@:>@])], > > - [want_libraw=$enableval]) > > + [AS_HELP_STRING([--disable-libraw],[disable libraw support. > @<:@default=enabled@:>@])], > > + [ > > + if test "x${enableval}" = "xyes" ; then > > + want_libraw="yes" > > + else > > + want_libraw="no" > > + fi > > + ], > > + [want_libraw="yes"]) > > > > AC_ARG_ENABLE([librsvg], > > - [AC_HELP_STRING([--enable-librsvg], [enable svg support > @<:@default==disabled@:>@])], > > - [want_rsvg=$enableval]) > > + [AS_HELP_STRING([--disable-librsvg],[disable svg support. > @<:@default=enabled@:>@])], > > + [ > > + if test "x${enableval}" = "xyes" ; then > > + want_rsvg="yes" > > + else > > + want_rsvg="no" > > + fi > > + ], > > + [want_rsvg="yes"]) > > > > have_poppler="no" > > have_spectre="no" > > > > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and > traffic > patterns at an interface-level. Reveals which users, apps, and protocols > are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity > planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
