> Sorry, release work taking its toll. I'm mostly fine with it. That's fine :-)
> Another > review would be great but if nobody steps up to do this we might as well > remove the experimental/beta status of it. Ok. >>>> This one looks redundant to me >>>> ECORE_COCOA_CURSOR_DEFAULT = ECORE_COCOA_CURSOR_ARROW >>>> Why would we need a ECORE_COCOA_CURSOR_DEFAULT enum type? We could use >>>> the _ARROW instead of _DEFAULT in all cases I can think of. >>> There are more X cursors than Cocoa cursors. >>> ECORE_COCOA_CURSOR_DEFAULT is used as a fallback when a cursor is >>> requested by an application, >>> but is not available. Maybe a #define would be more appropriate? > > Hmm, ok but why could we not use ECORE_COCOA_CURSOR_ARROW in that case > for the fallback? Why do we need a different enum? Because the default cursor is known and enforced by Ecore_Cocoa then. Without Ecore_Cocoa providing a "default" cursor, fallbacks would be implementation defined. This is typically used by elementary. When an X cursor is not available through Ecore_Cocoa, it uses ECORE_COCOA_CURSOR_DEFAULT instead. If another piece of code use the cursor API, is can use the same definition to use the default cursor, and does not have to guess which fallback to use. I can understand using the same enumeration feel a bit weird. I'm not quit sure how I feel about this. A macro would maybe make it more natural: #define ECORE_COCOA_CURSOR_DEFAULT ECORE_COCOA_CURSOR_ARROW >>>> What does ecore_cocoa_window_view_set() actually do? Just from the >>>> function name and docs I was not able to figure it out. Cocoa specifics? >>> In cocoa, a window (NSWindow) has a "content view" is the window >>> main container. This function allow to "set the contents of a window". >>> Maybe should I add a link to the cocoa documentation? > > This might be helpful. Ok, I will update the documentation then, when I'll be back home. ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
