devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=0f965446a823f9d5c5e02424d04eecc35da547e9

commit 0f965446a823f9d5c5e02424d04eecc35da547e9
Author: Chris Michael <cpmich...@osg.samsung.com>
Date:   Thu Jun 30 10:54:22 2016 -0400

    elput: Check return of read function call
    
    If we fail to read any bytes from the fd, then we should be returning
    a failure here.
    
    Fixes Coverity CID1357143
    
    @fix
    
    Signed-off-by: Chris Michael <cpmich...@osg.samsung.com>
---
 src/lib/elput/elput_input.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/elput/elput_input.c b/src/lib/elput/elput_input.c
index 1baf2f8..bff5503 100644
--- a/src/lib/elput/elput_input.c
+++ b/src/lib/elput/elput_input.c
@@ -40,8 +40,10 @@ _cb_open_restricted(const char *path, int flags, void *data)
         avail = select(p[0] + 1, &rfds, &wfds, &exfds, t);
         if (avail > 0)
           {
-             read(p[0], &fd, sizeof(int));
-             ret = fd;
+             if (read(p[0], &fd, sizeof(int)) < 1)
+               ret = -1;
+             else
+               ret = fd;
              break;
           }
         if (avail < 0) break;

-- 


Reply via email to