devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=dce25efef43f08ae28842f5eba5c807e54352ac1
commit dce25efef43f08ae28842f5eba5c807e54352ac1
Author: Chris Michael <cpmich...@osg.samsung.com>
Date: Thu Jun 30 10:59:28 2016 -0400
elementary: Fix explicit null dereference
This patch fixes an issue reported by coverity where 'type' variable
could be null and passing null to strcmp is not good ;)
Fixes Coverity CID1357147
@fix
Signed-off-by: Chris Michael <cpmich...@osg.samsung.com>
---
src/lib/elementary/elm_cnp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/elementary/elm_cnp.c b/src/lib/elementary/elm_cnp.c
index 7bb2190..a7f81ee 100644
--- a/src/lib/elementary/elm_cnp.c
+++ b/src/lib/elementary/elm_cnp.c
@@ -2697,9 +2697,9 @@ _wl_data_preparer_uri(Wl_Cnp_Selection *sel,
Elm_Selection_Data *ddata, Ecore_Wl
cnp_debug("In\n");
drop = eo_key_data_get(sel->requestwidget, "__elm_dropable");
- if (drop)
- type = drop->last.type;
- if (!strcmp(type, "text/uri-list"))
+ if (drop) type = drop->last.type;
+
+ if ((type) && (!strcmp(type, "text/uri-list")))
{
int num_files = 0;
char **files = NULL;
--
