tasn pushed a commit to branch master.
commit 041e3af3e55e28bedf955ebd098813a049040f08
Author: Tom Hacohen <[email protected]>
Date: Tue Aug 27 14:11:16 2013 +0100
Evas bidi: Fixed a bug causing BiDi not to work in some cases.
This issue cause non-letter RTL characters not to be detected as RTL
which in turn turned off bidi for those strings.
Example broken text: <RLM><LRO>[PAS<RLO>[--DES<PDF><PDF>.
Thanks to Yakov Goldberg for reporting this issue.
---
ChangeLog | 4 ++++
NEWS | 1 +
src/lib/evas/common/language/evas_bidi_utils.c | 2 +-
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index b43e680..f27fc70 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2013-08-27 Tom Hacohen
+
+ * Evas bidi: Fixed a bug causing BiDi not to work in some cases.
+
2013-08-20 David Seikel (onefang)
* Edje Lua: Check for both Lua 5.1 and 5.2.
diff --git a/NEWS b/NEWS
index e1d3418..e4fa3d0 100644
--- a/NEWS
+++ b/NEWS
@@ -329,6 +329,7 @@ Fixes:
- Fix infinite loop if app use ecore evas image
- Fix a long-standing off-by-1 in the C "simd" multiplier.
- Skip the map rendering if all points are transparent.
+ - Evas bidi: Fixed a bug causing BiDi not to work in some cases.
* Ecore:
- Don't leak fd on exec.
- Fix fd handler increase issue when ecore_pipe_add/del is called
repeatedly.
diff --git a/src/lib/evas/common/language/evas_bidi_utils.c
b/src/lib/evas/common/language/evas_bidi_utils.c
index afadcf2..b421a3a 100644
--- a/src/lib/evas/common/language/evas_bidi_utils.c
+++ b/src/lib/evas/common/language/evas_bidi_utils.c
@@ -87,7 +87,7 @@ evas_bidi_is_rtl_str(const Eina_Unicode *str)
for ( ; *str ; str++)
{
type = fribidi_get_bidi_type((FriBidiChar) *str);
- if (FRIBIDI_IS_LETTER(type) && FRIBIDI_IS_RTL(type))
+ if (FRIBIDI_IS_RTL(type))
{
return EINA_TRUE;
}
--
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
