tasn pushed a commit to branch evas-1.7.

commit f4ee588a803188fb499f5653a79070c307f08368
Author: Tom Hacohen <[email protected]>
Date:   Tue Aug 27 14:14:38 2013 +0100

    Evas bidi: Fixed a bug causing BiDi not to work in some cases.
    
    This issue cause non-letter RTL characters not to be detected as RTL
    which in turn turned off bidi for those strings.
    Example broken text: <RLM><LRO>[PAS<RLO>[--DES<PDF><PDF>.
    
    Thanks to Yakov Goldberg for reporting this issue.
---
 ChangeLog                                         | 4 ++++
 NEWS                                              | 1 +
 src/lib/engines/common/language/evas_bidi_utils.c | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index a141fbc..51363d5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1348,3 +1348,7 @@
 
         * Evas textblock: Added proper size adjustments for "high" shaped 
texts.
 
+2013-08-27  Tom Hacohen
+
+        * Evas bidi: Fixed a bug causing BiDi not to work in some cases.
+
diff --git a/NEWS b/NEWS
index 2f0ae6c..6661596 100644
--- a/NEWS
+++ b/NEWS
@@ -7,6 +7,7 @@ Fixes:
    * Evas textblock: Fixed issue when parsing formats with quotes.
    * Evas textblock: Make the ellipsis format the same as the surrounding.
    * Evas textblock: Added proper size adjustments for "high" shaped texts.
+   * Evas bidi: Fixed a bug causing BiDi not to work in some cases.
 
 Evas 1.7.8
 
diff --git a/src/lib/engines/common/language/evas_bidi_utils.c 
b/src/lib/engines/common/language/evas_bidi_utils.c
index f05cc09..e2d9f70 100644
--- a/src/lib/engines/common/language/evas_bidi_utils.c
+++ b/src/lib/engines/common/language/evas_bidi_utils.c
@@ -87,7 +87,7 @@ evas_bidi_is_rtl_str(const Eina_Unicode *str)
    for ( ; *str ; str++)
      {
         type = fribidi_get_bidi_type((FriBidiChar) *str);
-        if (FRIBIDI_IS_LETTER(type) && FRIBIDI_IS_RTL(type))
+        if (FRIBIDI_IS_RTL(type))
           {
              return EINA_TRUE;
           }

-- 

------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk

Reply via email to