Le 9 févr. 05, à 11:28, M. Uli Kusterer a écrit :

Quentin,

 just looking at the IconKit headers. A few notes/questions:

-> Why are you generating a hash from the bundle identifier? Wouldn't the cache be more readable in the file system if you just used the plain-text bundle identifier?

For compatibility with Freedesktop thumbnails specification… I have done the same for the icons, but it isn't really needed probably.
http://jens.triq.net/thumbnail-spec/index.html

-> In _obtainBundlePathIfNeeded, you can't use bundleWithIdentifier:. bundleWithIdentifier only works for objects that have already been loaded into your app. At least that's what Apple's docs say. You'll have to write your own code that keeps track of bundle paths associated with particular identifiers and lets clients look that up.

I know it doesn't work currently, but I projected to fix it by extending GNUstep code directly or with a category to support that by querying the make_services database (which is equivalent to LaunchServices database on Mac OS X)

-> It should be "invalidateCache" and "invalidateAllCaches". invalid is an adjective in English and people would expect it to return a boolean whether the cache is valid or not.

Thanks for this point, my English is not really good sorry :-/

Quentin.

--
Quentin Mathé
[EMAIL PROTECTED]


Reply via email to