On Mon, Mar 02, 2009 at 10:50:14AM +0000, David Chisnall wrote: > The GNUmakefile patch for EtoileFoundation will break compilation on > x86-32. That line needs to be wrapped in a conditional so that it is > only added on x86-32, not on other platforms. If someone more > familiar with GNUstep Make than me wants to submit a patch that does > that then I'd be happy to commit it before 0.4.1.
gnustep-make provides a GNUSTEP_TARGET_CPU variable [1] that could be used. The attached patch does probably aleviate the build issue on 64ibit intel platforms by setting the compiler flag only on i[3456]86 platforms. If I understood correctly, the build will still fail for sub i586 platforms, but should work for all other 32bit intel system. (Unfortunately, I have no machine to test this). best regards, Niels [1] http://www.gnustep.org/resources/documentation/make_1.html#SEC33
<<< message/external-body; access-type=x-mutt-deleted; expiration="Mon, 2 Mar 2009 12:29:05 +0100"; length=398: Unrecognized >>>
Index: Frameworks/EtoileFoundation/GNUmakefile =================================================================== --- Frameworks/EtoileFoundation/GNUmakefile (revision 4469) +++ Frameworks/EtoileFoundation/GNUmakefile (working copy) @@ -86,7 +86,9 @@ EtoileFoundation_HEADER_FILES += NSFileManager+NameForTempFile.h endif +ifeq ($(GNUSTEP_TARGET_CPU), ix86) ADDITIONAL_OBJCFLAGS += -march=i586 +endif include $(GNUSTEP_MAKEFILES)/aggregate.make -include ../../etoile.make
_______________________________________________ Etoile-dev mailing list [email protected] https://mail.gna.org/listinfo/etoile-dev
