On 15 Apr 2001, Ettore Perazzoli wrote:

 Hi, 

> On 14 Apr 2001 11:43:22 +0500, Vlad Harchev wrote:
> >  In most cases, the "always black" problem is due to not calling
> > "gtk_widget_ensure_style(widget)" before making modifications to copy
> > of widget's GtkStyle.
> > 
> >  It would be nice if all Ximian's and Eazel's products were tested with
> > non-standard gtk themes such as SatinBlack to ensure that they are gtk
> > theme-friendly.
> 
>   I agree we should fix these problems.  We are interested in being
> theme friendly as much as you are.  :-)

 :)

>   One issue I have had in the past with theme engines is that they often
> hardcode things in a non-friendly way, by doing things like
> 
>     if (GTK_IS_ENTRY (widget))
>         use_this_color();
>     else
>         use_this_other_color();
> 
> This messes up all of our custom widgets in an unfixable way.

 Hmm, then for reliability a plain theme (that doesn't use any theme engines)  
should be written that uses very dark color for background of everything and
white for text color. All theme-unfriendly code will be easiliy detected with
it. And better stick huge font size for that theme too - all naive code that
hardcodes size of windows (as it was in Nautilus) and uses non-standard font
for no reason also will be catchable with it. 
 It would be nice if this theme could be uploaded to developer.gnome.org and
advertised as theme-friendliness testsuite. 
 I can cook up such theme if you wish.

>   Anyway, I am not sure if it's the case with this theme.  I am going to
> submit this stuff into Bugzilla right now...  Of course we accept
> patches too.  :-)

 Sorry, I don't have time to hack on this.. But it's all trivial to fix, at
least GAL and color of text in selected item in the message list.

 Also remember: when printing, Evolution uses *text color from gtk theme* and
color user specified for quoted text as color to print text with - so when
printing I'm getting WHITE or yellow text on WHITE paper. This nonsense should
be fixed - controls for selecting color of normal text and quoted text for
printing should be available to the user.

 After all this gets fixed, Evolution will be theme friendly.

> -- 
> Ettore
> 

 Best regards,
  -Vlad


_______________________________________________
evolution-hackers maillist  -  [EMAIL PROTECTED]
http://lists.helixcode.com/mailman/listinfo/evolution-hackers

Reply via email to