Hi, Petr, Just checked in your patch along with some changes to implement the option for building contrib directory. The new SVN version is 515. Please give it a try when you get the chance and let us know if you encounter any problems.
By the way, the configure option for building contrib directory is --enable-contrib Thanks for the input. John On 4/13/12 9:43 AM, Petr Velan wrote: > Hi John, > > you are right, I've just tested the Makefile in fbmerge directory, > which did not work properly itself. > > There are few possible ways to solve the problem. You can create > another configure, but i believe that the contrib directory will be > along the fastbit library most of the time. > Maybe you could make the contrib (or contrib/fbmerge) directory built > optionally, depending on configure argument. The GNU documentation has > just the example I was looking for: > http://www.gnu.org/software/automake/manual/html_node/Subdirectories-with-AM_005fCONDITIONAL.html > This may seem not to solve the problem, but the automake detects that > the directory is added conditionally and runs make distclean in that > directory. > > I hope this works for you, > Petr > > On 13 April 2012 17:33, K. John Wu <[email protected]> wrote: >> Hi, Petr, >> >> The problem seems to be that the main Makefile.am does not include >> contrib directory, and therefore the contrib/fbmerge is not really >> linked to the make system at the higher level. I have not figure out >> out to do a conditional build for a directory like this. Looks like >> the easiest thing might be to create a separate configure.ac in >> contrib directory and ask users who wants the things in contrib to >> build things there separately. Any better suggestion? >> >> John >> >> >> On 4/13/12 1:15 AM, Petr Velan wrote: >>> Hi John, >>> >>> as I'm working with the build system, I've noticed one small thing. >>> The distclean target does not remove the contrib/fbmerge/Makefile >>> properly. >>> >>> The problem is with missing newline before distclean rule, but I would >>> recommend using distclean-local target, which is the correct automake >>> way to tap into distclean target. The appropriate diff is attached. >>> Sine it comes from git-diff, use >>> patch -p1 < Makefile.am.patch >>> to apply. >>> >>> Petr >>> >>> On 13 April 2012 01:36, K. John Wu <[email protected]> wrote: >>>> Hi, Petr, >>>> >>>> Thanks for spotting this problem. I will add fastbit-config.h to the >>>> list file to be installed. >>>> >>>> The people who has to define WITHOUT_FASTBIT_CONFIG_H would be most >>>> likely those not on a unix system, i.e., without autoconf or automake. >>>> Based on this assumption, I can simply add the files to the list be >>>> to handled through automake. There seems to be no need for >>>> conditional handling of this file. Let me know if you have a case >>>> where the conditional handling is necessary. >>>> >>>> Thanks again. >>>> >>>> John >>>> >>>> >>>> On 4/12/12 11:52 AM, Petr Velan wrote: >>>>> Hi John, >>>>> >>>>> I've just downloaded, compiled and packaged latest revision of the >>>>> FastBit library. Everything was OK, but now when I try to use it, >>>>> const.h tries to include fastbit-config.h, which is not installed. >>>>> I've noticed that there is WITHOUT_FASTBIT_CONFIG_H macro that would >>>>> probably solve this, but I expect that the fastbit-config.h header >>>>> should be conditionally (based on the WITHOUT_FASTBIT_CONFIG_H) >>>>> distributed amongst other installed headers. >>>>> >>>>> Petr _______________________________________________ FastBit-users mailing list [email protected] https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users
