Hello, * Horms <[EMAIL PROTECTED]> [2007-02-13 10:19]: > On Tue, Feb 13, 2007 at 09:08:06AM +0800, Zou, Nanhai wrote: > > > -----Original Message----- > > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED] On Behalf Of Bernhard Walle > > > Sent: 2007年2月13日 5:50 > > > To: [email protected]; Linux-IA64 > > > Subject: Re: [Fastboot] Zero size /proc/vmcore on ia64 > > > > > > * Bernhard Walle <[EMAIL PROTECTED]> [2007-02-12 19:57]: > > > > * Zou, Nanhai <[EMAIL PROTECTED]> [2007-02-09 00:45]: > > > > > I have not implement serial print in purgatory code yet, see > > > > > comments in purgatory/arch/ia64/console-ia64.c However from your > > > > > print, I can see last 2 entries of efi mem map are corrupt. > > > > > > > > I have the same problem (corrupted memory map entries), and the cause > > > > was in kexec-tools, patch below. I'm not sure if the fix is right, at > > > > least the problem is the uninitialised value of size. :) > > > > > > But that patch doesn't fix the zero-size problem, it just fixes the > > > invalid EFI map problem. That patch (against kexec-tools, not against > > > the kernel) fixes both. > > > > > > The problem is simply that the space for the core header doesn't > > > occupy a EFI page. > > Thanks a lot for working that out. It does indeed seem to solve the > problem, though I wonder adding an alignment parameter to > crash_create_XXX_headers(), as per the patch below, is a better > way to achive this.
Aggreed. I just wanted to discuss the quick solution. > > The kexec-tools version seems to be different. > > I believe that Bernhard is using the kexec-tools-testing tree. > It would be totally awsome if you could check that code > out some time and see if it works for you. Yes, I (and our Linux distribution) is using that tree. Is there another, up-to-date tree? http://www.xmission.com/~ebiederm/files/kexec/ seems to be a bit outdated. I tested your patch and it works fine here. Just a comment: > > Index: kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c > =================================================================== > --- kexec-tools-bw.orig/kexec/arch/ia64/crashdump-ia64.c 2007-02-13 > 17:39:18.000000000 +0900 > +++ kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c 2007-02-13 > 18:09:44.000000000 +0900 > @@ -232,13 +232,14 @@ > if (crash_create_elf64_headers(info, &elf_info, > crash_memory_range, > nr_ranges, > - &tmp, &sz) < 0) > + &tmp, &sz, > + 4096) < 0) Why not using EFI_PAGE_SIZE here? It would also be good to find a suitable constant name for 1024. Regards, Bernhard _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
