On Tue, Feb 13, 2007 at 06:03:20PM +0100, Bernhard Walle wrote:
> > Index: kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c
> > ===================================================================
> > --- kexec-tools-bw.orig/kexec/arch/ia64/crashdump-ia64.c    2007-02-13 
> > 17:39:18.000000000 +0900
> > +++ kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c 2007-02-13 
> > 18:09:44.000000000 +0900
> > @@ -232,13 +232,14 @@
> >                     if (crash_create_elf64_headers(info, &elf_info,
> >                                                    crash_memory_range,
> >                                                    nr_ranges,
> > -                                                  &tmp, &sz) < 0)
> > +                                                  &tmp, &sz,
> > +                                                  4096) < 0)
> 
> Why not using EFI_PAGE_SIZE here? It would also be good to find a
> suitable constant name for 1024.

Indeed, I meant to use EFI_PAGE_SIZE instead of 4096.
I'll fix that up and apply.

As for a good constant name, I'm open to suggestions.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to