Mark McLoughlin wrote:
With e.g.:

  repo --name=rawhide --baseurl=http://foo

  %packages
  %end

You get:

  OSError: Got an error from /usr/lib/anaconda-runtime/buildinstall:

and trying out the buildinstall command directly, you see:

  Running buildinstall...
  No Match for argument anaconda-runtime
  Nothing to download

The issue here is that one of the first things buildinstall
tries to do is install anaconda-runtime from the supplied
repository, so the user must add anaconda-runtime to the
package list or pungi fails.

Automatically add it to the package list rather than
requiring the user to do it.


Because pungi doesn't pull in *any* "required" packages, I was reluctant to submit this patch... It seems that once you go down this road you will want to catch *all* required packages, like we do in Revisor (and creates a very, very long list[1]).

Kind regards,

Jeroen van Meeuwen
-kanarip

[1] http://git.fedorahosted.org/git/?p=revisor;a=blob;f=revisor/cfg.py#l1165
diff --git a/src/pypungi/gather.py b/src/pypungi/gather.py
index 49247f2..2a027c2 100644
--- a/src/pypungi/gather.py
+++ b/src/pypungi/gather.py
@@ -275,6 +275,9 @@ class Gather(pypungi.PungiBase):
         # Make the search list unique
         searchlist = yum.misc.unique(searchlist)
 
+        if not "anaconda-runtime" in searchlist:
+            searchlist.append("anaconda-runtime")
+
         # Search repos for things in our searchlist, supports globs
         (exactmatched, matched, unmatched) = yum.packages.parsePackages(self.ayum.pkgSack.returnPackages(), searchlist, casematch=1)
         matches = filter(self._filtersrc, exactmatched + matched)
--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

Reply via email to