Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467416 Erik van Pienbroek <erik-fed...@vanpienbroek.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fed...@vanpienbroek.nl AssignedTo|nob...@fedoraproject.org |erik-fed...@vanpienbroek.nl Bug 467416 depends on bug 467397, which changed state. Bug 467397 Summary: Review Request: mingw32-libpng - MinGW Windows Libpng library https://bugzilla.redhat.com/show_bug.cgi?id=467397 What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED --- Comment #3 from Erik van Pienbroek <erik-fed...@vanpienbroek.nl> 2009-01-17 09:18:58 EDT --- I see you've used these commands in the %install phase: rm -f $RPM_BUILD_ROOT%{_mingw32_libdir}/charset.alias rm -f $RPM_BUILD_ROOT%{_mingw32_libdir}/libcairo.a Why is the charset.alias file removed? Why haven't you used %configure --disable-static to prevent building the static library? Do we really want to pull in freetype and fontconfig as a dependency? Cairo provides a native Win32 implementation for font rendering, so I guess adding a dependency on freetype and fontconfig only introduces unnecessary bloat. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
