Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=464781 --- Comment #26 from Dominik 'Rathann' Mierzejewski <r...@greysector.net> 2009-01-20 15:40:41 EDT --- Some more comments: Requires: libX11 >= 1.1.4 Why do you need a specific libX11 version? Please add a comment with an explanation. Also, please sort both Requires: and BuildRequires: alphabetically for better readability. %description FlexDock is a Java docking framework for use in cross-platform Swing applications Why is the description indented? Also, it's missing the end period. #Modify the jni dir that is hardcoded in the patch cp -pf %{PATCH0} %{PATCH0}.tmp sed -i 's!%%{_libdir}/%%{name}/!%{_libdir}/%{name}/!' %{PATCH0} Why don't you just modify the patch? if [ `uname -m` == "x86_64" ] || [ `uname -m` == "ppc64" ] ; then JDK_DIR=`echo %{_jdkdir} | sed 's!/$!!'`.`uname -m` I suggest using a case statement here. It'll be easy to add other arches later. For example sparc64. #OK # Apache commons Logging component # http://commons.apache.org/logging/ # ./lib/commons-logging-1.1.jar rm -f ./lib/commons-logging-1.1.jar ln -s %{_javadir}/commons-logging.jar ./lib/commons-logging-1.1.jar #remove jmf, as it is only used in a demo, #which is unused after patching rm -rf ./lib/jmf/ #" Looks" project # https://looks.dev.java.net/ rm -f ./lib/looks-2.1.1.jar ln -s %{_javadir}/jgoodies-looks.jar ./lib/looks-2.2.1.jar #skinlf "Skin look and Feel" project # https://skinlf.dev.java.net/ rm -f ./lib/skinlf.jar ln -s %{_javadir}/skinlf.jar ./lib/skinlf.jar Manually making symlinks is fragile, especially for versioned JARs. It'll break when their version changes. I think you should use build-jar-repository for that: https://fedoraproject.org/wiki/Packaging/Java#build-jar-repository dos2unix -d2u $i; What does -d2u option do? It's not documented in --help or in the manpage. flexdock has funny arch flags, such as "libRubberBand-linux-x86.so" on i386 SOFILE=`find ./ -name libRubberBand*so` Couldn't you just patch the build system not to put arch in lib filename? strip --strip-unneeded $SOFILE Calling strip from the specfile is not allowed. rpm post-build scripts do that while building the debuginfo package. %post -p /sbin/ldconfig %postun -p /sbin/ldconfig These are not needed, as the library is not in ld.so search path (and not directly linkable). *Tue Jan 20 2009 <mycae(a!t)yahoo.com> 0.5.1-8 - Set defattr - Fix arch (again) - Change install dir from %%libdir to %%libdir/%%name - Update patch0 to match changed so dir + make dynamic *Sat Dec 20 2008 <mycae(a!t)yahoo.com> 0.5.1-7 - Re-enable system skinlf link & jar check. Changelog entries must have a space between * and date. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
