Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: expect https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225743 ------- Additional Comments From [EMAIL PROTECTED] 2007-02-07 09:59 EST ------- Thanks! * Use of buildroot is not consistant Changed to use "$RPM_BUILD_ROOT" everywhere. * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Fixed. * Spec file: some paths are not replaced with RPM macros /usr/share/man replaced by %{_mandir} * The package should contain the text of the license It does, in /usr/share/expect-*/README: | I hereby place this software in the public domain. NIST and I would | appreciate credit if this program or parts of it are used. * Duplicate BuildRequires: tcl-devel (by tk-devel), libX11-devel (by tk-devel), autoconf (by automake) Because expect explicitly refers to tcl-devel and autoconf it IMHO should BuildRequire it explicitly; this is unrelated to the question whether e.g. automake depends on autoconf. BuildRequires: libX11-devel removed, expect doesn't directly refer to libX11. * Please use {?dist} in the Release tag I'd rather not; as long as each Fedora release uses a different NEVR, the dist tag is IMHO just useless clutter. * Can you use make DESTDIR instead of make INSTALLROOT? No, Makefile.in doesn't support this aspect of GNU coding standards and the variable is called INSTALL_ROOT. * Replace /usr/share/man with %{_docdir} everywhere ... with %{_mandir}, done. * Are you willing to consider building with --disable-static. You're not packaging static libraries, and this saves some build time. expect doesn't support --disable-static. * If one of the packages is a gui application, a .desktop file should be installed expectk is a programming language interpreter, I don't think it can be considered a GUI application (try running it). E: expect script-without-shebang /usr/lib/expect5.43/pkgIndex.tcl * Fixed by making the file unexecutable E: expect wrong-script-interpreter /usr/lib/expect5.43/cat-buffers "expect" E: expect non-executable-script /usr/lib/expect5.43/cat-buffers 0644 * Both Fixed by removing the file altogether E: expect invalid-soname /usr/lib/libexpect5.43.so libexpect5.43.so I'll try to clean this up tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
