On 4/17/2020 10:27 AM, Nicolas George wrote: > James Almer (12020-04-17): >> The change is effectively just the keyframe flag being added to audio >> packets in all of the movenc tests. >> >> To verify, simply apply > <snip> >> without your patch, and you'll get the same changes in the test. > > I would be more comfortable with the information that it was checked > externally. For example by checking the output of ffprobe on the > produced files before and after the patch. Seems like an obvious step. > > Regards,
The movenc test does not produce any files. It creates bogus packets that are dumped into the AVOutputFormat output using a custom AVIOContext on each stream that just calculates an md5 hash of the data. I think the one line change i posted is enough to reproduce the changes, and we don't need the patch author to essentially rewrite the movenc test just to dump everything into a file we can pass to ffprobe that may or may not be parseable to begin with. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
