> From: Martin Storsjö <mar...@martin.st> > Sent: Tuesday, April 28, 2020 03:35 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Cc: Fu, Linjie <linjie...@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH v4 3/9] lavc/libopenh264enc: add bit > rate control select support > > On Wed, 15 Apr 2020, Linjie Fu wrote: > > > RC_BITRATE_MODE: > > set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust > > in RcCalculatePictureQp(). > > > > RC_BUFFERBASED_MODE: > > use buffer status to adjust the video quality. > > > > RC_TIMESTAMP_MODE: > > bit rate control based on timestamp. > > > > Default to use RC_QUALITY_MODE. > > > > Signed-off-by: Linjie Fu <linjie...@intel.com> > > --- > > libavcodec/libopenh264enc.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > This looks ok, but I don't think all of these have been available since > the beginning. We do support building with a few older versions of the > library, so I think at least RC_TIMESTAMP_MODE appeared later. The lowest > version that was supported originally was OpenH264 1.3, so for things that > have appeared later, please add ifdefs (or consistently bump the minimum > version somewhere and remove redundant checks for lower versions). >
Double checked this in the release history: RC_BUFFERBASED_MODE was introduced since release 1.2; RC_TIMESTAMP_MODE was introduced since release 1.4. Updated. - Linjie _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".