> From: Martin Storsjö <mar...@martin.st> > Sent: Tuesday, April 28, 2020 04:02 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Cc: Fu, Linjie <linjie...@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH v4 6/9] lavc/libopenh264enc: separate > svc_encode_init() into several functions > > On Wed, 15 Apr 2020, Linjie Fu wrote: > > > Separate the initialization procedure into different functions. > > > > Make it more readable and easier to be extended. > > > > Signed-off-by: Linjie Fu <linjie...@intel.com> > > --- > > libavcodec/libopenh264enc.c | 283 +++++++++++++++++++++++++++----- > ------------ > > 1 file changed, 174 insertions(+), 109 deletions(-) > > I honestly don't see the point here. Yes, the init function is long, but > you're moving code around and making it even 65 lines longer in total... > > In which way is this easier to extend than the previous form?
This patch simply adds some wrappers for the existed code, hence it's true it'll be longer. IMO a hierarchical function structure seems to be more clear and readable, hence easier for developer and user. However I don't have much strong intention for this. If it's not a good idea, I'll separate this patch set and get the functional patches merged firstly, thx. - Linjie _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".